-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow a different Apache port with APACHE_PORT #369
Conversation
I don't believe we need to do this for either fpm variant, because neither of those should include Apache. Aside from that, this looks good to me, thanks for the contribution. |
Makes sense, I did a quick pass again, hope it's good this time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This contribution looks nice, thank you!
Okay added an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I will probably write a test for it, or maybe you can try to do it
👋 I saw there were a few new commits in |
Thanks, I did some testing improvements to easily add a new test for this one |
Here is the test: 3c16423 Thank you for this contribution @devinmatte ! |
It is live on https://hub.docker.com/_/phpmyadmin ! |
To deal with both #340 and #187, this PR allows for a new Environment variable
APACHE_PORT
to change the default port from80
to something user defined. If unset, it remains using port 80Fixes: #340