Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Add "--xdebug" CLI option to enabled Xdebug #1158

Open
wants to merge 8 commits into
base: 3.x
Choose a base branch
from
Open

[3.x] Add "--xdebug" CLI option to enabled Xdebug #1158

wants to merge 8 commits into from

Conversation

ravage84
Copy link
Member

Type: Feature
Issue: Resolves None
Breaking change: No

Inspired by https://dev.to/serendipityhq/how-to-debug-any-symfony-command-simply-passing-x-214o

This could easily be a feature of composer/xdebug-handler itself, if they would want to.

@ravage84 ravage84 self-assigned this May 15, 2024
@codecov Codecov
Copy link

codecov bot commented May 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 5.26316% with 18 lines in your changes missing coverage. Please review.

Project coverage is 91.48%. Comparing base (5444160) to head (afa75e0).

Files Patch % Lines
src/main/php/PHPMD/TextUI/XdebugOptionHandler.php 0.00% 18 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                3.x    #1158      +/-   ##
============================================
- Coverage     91.96%   91.48%   -0.49%     
- Complexity     1290     1296       +6     
============================================
  Files           107      108       +1     
  Lines          3398     3417      +19     
============================================
+ Hits           3125     3126       +1     
- Misses          273      291      +18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AJenbo
Copy link
Member

AJenbo commented May 15, 2024

This could easily be a feature of composer/xdebug-handler itself, if they would want to.

Did you propose the change upstream?

@ravage84
Copy link
Member Author

Did you propose the change upstream?

Not yet

AJenbo
AJenbo previously approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@AJenbo AJenbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just don't forget to remove it if they accept it upstream :D

@ravage84 ravage84 added this to the 3.0.0 milestone May 24, 2024
kylekatarnls
kylekatarnls previously approved these changes Jun 10, 2024
View reviewed changes
kylekatarnls
kylekatarnls requested changes Jun 10, 2024
View reviewed changes
Copy link
Member

@kylekatarnls kylekatarnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, we just need a unit test to cover src/main/php/PHPMD/TextUI/XdebugOptionHandler.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylekatarnls kylekatarnls kylekatarnls requested changes

@AJenbo AJenbo AJenbo left review comments

Requested changes must be addressed to merge this pull request.

Assignees

@ravage84 ravage84

Labels
Dependencies Feature Needs Tests PHAR Issues related to the phar file. RFC
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ravage84 @AJenbo @kylekatarnls