Skip to content

fix: null-safe check of query string key closes #226 #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 24, 2025
Merged

fix: null-safe check of query string key closes #226 #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a739a2d
fix: null-safe check of query string key
g105b Oct 24, 2025
f936826
tweak: remove non-existent test
g105b Oct 24, 2025
f988bb0
ci: add codecov token
g105b Oct 24, 2025
3afbea4
ci: add codecov slug
g105b Oct 24, 2025
a2a3e87
ci: tweak slug
g105b Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,9 @@ jobs:

- name: Upload to Codecov
uses: codecov/codecov-action@v5
with:
token: ${{ secrets.CODECOV_TOKEN }}
slug: PhpGt/Http

phpstan:
runs-on: ubuntu-latest
Expand Down
1 change: 0 additions & 1 deletion phpcs.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
<rule ref="Generic.Files.OneObjectStructurePerFile" />
<rule ref="Generic.Files.OneTraitPerFile" />
<rule ref="Generic.Formatting.DisallowMultipleStatements" />
<rule ref="Generic.Formatting.NoSpaceAfterCast" />
<rule ref="Generic.Functions.FunctionCallArgumentSpacing" />
<rule ref="Generic.Functions.OpeningFunctionBraceKernighanRitchie" />
<rule ref="Generic.Metrics.CyclomaticComplexity" />
Expand Down
2 changes: 1 addition & 1 deletion src/ServerRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public function withCookieParams(array $cookies):self {
* @return array<string, string|array<string>>
*/
public function getQueryParams():array {
parse_str($this->serverData["QUERY_STRING"], $params);
parse_str($this->serverData["QUERY_STRING"] ?? "", $params);
/** @var array<string, string|array<string>> $params */
return $params;
}
Expand Down
Loading