Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespace handling for defines and namespaced constants #157

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

dirx
Copy link
Contributor

@dirx dirx commented Mar 3, 2020

Solves #156

Handling define(__NAMESPACE__ . '\\NS_CONST') is not part of this.

@jaapio
Copy link
Member

jaapio commented Jun 19, 2020

This looks good to me.
Thanks for this contribution!

@jaapio jaapio closed this Jun 19, 2020
@jaapio jaapio reopened this Jun 19, 2020
@jaapio jaapio merged commit 50ffd77 into phpDocumentor:master Jun 19, 2020
@dirx dirx deleted the issue-156 branch June 19, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants