ext/spl: refactor class autoloading to use newer FCC APIs #20841
+64
−163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndossche
requested changes
Jan 10, 2026
| } | ||
|
|
||
| zend_hash_next_index_insert_ptr(spl_autoload_functions, alfi); | ||
| zend_fcall_info_cache *entry = emalloc(sizeof(zend_fcall_info_cache)); |
Member
There was a problem hiding this comment.
Could use zend_hash_next_index_insert_mem here
Member
Author
There was a problem hiding this comment.
I don't think this is correct, as I need to do a "deep" copy of the FCC by increasing refcounts rather than a shallow dup. Will add a comment to explain this.
Remove unused parameter Use zend_string_concat2() API Use size_t for ext_len parameter type Return bool instead of int
This is used only once anyway
Girgias
force-pushed
the
autoloader-fcc-api
branch
from
9304196 to
cb596b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits should be reviewed individually.
The primary motivation for me to introduce the newer FCC APIs was to make it easier to handle userland callables as the class autoloading system had a few bugs due to the complex semantics.
This is effectively taking the class autoloading part of #8294 as it is a straight-up code clarity improvement.