Update OpenBSD glob implementation for Windows #16948
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MSVC error there is misleading, it's missing |
From OpenBSD, dependency of newer versions of glob.
NattyNarwhal
force-pushed
the
glob-update
branch
from
41594b5
to
affa4a7
Compare
We're considering making this used as a glob implementation on POSIX as well, but first, we should rebase it from the latest version of OpenBSD. This also adds a new internal header (charclass.h) for glob. See conversation in phpGH-15564.
NattyNarwhal
force-pushed
the
glob-update
branch
from
affa4a7
to
48fbd32
Compare
See #16986.
Might be best, unless that would be a PITA when pulling in further updates. |
|
For now I imported reallocarray. I don't think glob changes much, so future changes from OpenBSD should be easy to reconcile even if we do convert to ZendMM in the future. Now, to figure out what's broken... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're considering making this used as a glob implementation on POSIX as well, but first, we should rebase it from the latest version of OpenBSD.
This also adds a new internal header (charclass.h) for glob.
See conversation in GH-15564.