GH-16889: stream_select() timeout useless for pipes on Windows #16917
+45
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pipes are blocking on Windows, but `php_select()` always returns them as ready for read/write. This renders the `stream_select()` timeout useless, what can cause a following read to block for a very long time. While there is no general fix (and least not within reach for a stable version), we can at least cater to the important case of read pipes by peeking the pipe to check whether data is available. If there is none, we do not add the handle to the read set.
The test assumes that at least the stdin and stdout pipes are always selected as readable, and that the select call will not change their order. We're being more defensive now.
|
This now waits indefinitely on Windows, what it is supposed to do according to man 2 select, since we're passing PS: ah, because reading files won't block there. PPS: it's not supposed to block indefinitely; we must not call |
* bug60602.phpt has the same issue as bug64770.phpt (copy&paste) * bug49936_win32.phpt should suppress the warnings[1], or be dropped altogether[2] [1] <php@c884d37> [2] <php@2c6b85f>
`FILE_TYPE_PIPE` will also be returned for sockets, but these have been filtered out already.
|
Given that I had to patch a couple of test cases, it might make sense to only apply this to master. However, in https://bugs.php.net/bug.php?id=51800#1561307300, @nicolas-grekas wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipes are blocking on Windows, but
php_select()always returns them as ready for read/write. This renders thestream_select()timeout useless, what can cause a following read to block for a very long time.While there is no general fix (and least not within reach for a stable version), we can at least cater to the important case of read pipes by peeking the pipe to check whether data is available. If there is none, we do not add the handle to the read set.