Introduce a special FPM event pid callback #10510
Conversation
| @@ -480,11 +480,14 @@ void fpm_event_loop(int err) /* {{{ */ | |||
|
|
|||
| void fpm_event_fire(struct fpm_event_s *ev) /* {{{ */ | |||
| { | |||
| if (!ev || !ev->callback) { | |||
| if (!ev || !ev->ptr_callback) { | |||
There was a problem hiding this comment.
ptr_callback or pid_callback should be checked below, after dispatch based on pid.
There was a problem hiding this comment.
It's union so the same memory is used so if one is NULL, then the other one is NULL as well.
There was a problem hiding this comment.
Of course this is true, but this is not explicitly apparent when reading this code and could be easily forgotten if the structure is modified.
| union { | ||
| void (*ptr_callback)(struct fpm_event_s *, short, void *); | ||
| void (*pid_callback)(struct fpm_event_s *, short, pid_t pid); | ||
| }; |
There was a problem hiding this comment.
Propose to document in a comment how the proper field should be selected (pid != 0).
There was a problem hiding this comment.
yeah will add a comment if this is confirmed working :)
|
Passing pid should not be actually necessary and the problem was more about accessing the event after free. So closing this in favour of #11084 . |
This is an attempt to fix #10461 - needs OP verification