Skip to content

metrics/perf: use WithLabelValues instead #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dunglas merged 2 commits into from
Mar 24, 2025
Merged

metrics/perf: use WithLabelValues instead #1450

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81c6ae0
Uses WithMetricLabels instead.
AlliBalliBaba Mar 22, 2025
913ba36
trigger build
AlliBalliBaba Mar 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 12 additions & 18 deletions metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,6 @@ type PrometheusMetrics struct {
mu sync.Mutex
}

func (m *PrometheusMetrics) getLabels(name string) prometheus.Labels {
return prometheus.Labels{"worker": name}
}

func (m *PrometheusMetrics) StartWorker(name string) {
m.busyThreads.Inc()

Expand All @@ -109,15 +105,15 @@ func (m *PrometheusMetrics) StartWorker(name string) {
return
}

m.totalWorkers.With(m.getLabels(name)).Inc()
m.totalWorkers.WithLabelValues(name).Inc()
}

func (m *PrometheusMetrics) ReadyWorker(name string) {
if m.totalWorkers == nil {
return
}

m.readyWorkers.With(m.getLabels(name)).Inc()
m.readyWorkers.WithLabelValues(name).Inc()
}

func (m *PrometheusMetrics) StopWorker(name string, reason StopReason) {
Expand All @@ -128,14 +124,13 @@ func (m *PrometheusMetrics) StopWorker(name string, reason StopReason) {
return
}

metricLabels := m.getLabels(name)
m.totalWorkers.With(metricLabels).Dec()
m.readyWorkers.With(metricLabels).Dec()
m.totalWorkers.WithLabelValues(name).Dec()
m.readyWorkers.WithLabelValues(name).Dec()

if reason == StopReasonCrash {
m.workerCrashes.With(metricLabels).Inc()
m.workerCrashes.WithLabelValues(name).Inc()
} else if reason == StopReasonRestart {
m.workerRestarts.With(metricLabels).Inc()
m.workerRestarts.WithLabelValues(name).Inc()
}
}

Expand Down Expand Up @@ -262,31 +257,30 @@ func (m *PrometheusMetrics) StopWorkerRequest(name string, duration time.Duratio
return
}

metricLabels := m.getLabels(name)
m.workerRequestCount.With(metricLabels).Inc()
m.busyWorkers.With(metricLabels).Dec()
m.workerRequestTime.With(metricLabels).Add(duration.Seconds())
m.workerRequestCount.WithLabelValues(name).Inc()
m.busyWorkers.WithLabelValues(name).Dec()
m.workerRequestTime.WithLabelValues(name).Add(duration.Seconds())
}

func (m *PrometheusMetrics) StartWorkerRequest(name string) {
if m.busyWorkers == nil {
return
}
m.busyWorkers.With(m.getLabels(name)).Inc()
m.busyWorkers.WithLabelValues(name).Inc()
}

func (m *PrometheusMetrics) QueuedWorkerRequest(name string) {
if m.workerQueueDepth == nil {
return
}
m.workerQueueDepth.With(m.getLabels(name)).Inc()
m.workerQueueDepth.WithLabelValues(name).Inc()
}

func (m *PrometheusMetrics) DequeuedWorkerRequest(name string) {
if m.workerQueueDepth == nil {
return
}
m.workerQueueDepth.With(m.getLabels(name)).Dec()
m.workerQueueDepth.WithLabelValues(name).Dec()
}

func (m *PrometheusMetrics) QueuedRequest() {
Expand Down