Currentlive #214
Currentlive #214
Conversation
| @@ -157,6 +156,15 @@ | |||
| ), | |||
| ), | |||
| ), | |||
| 'dataprivacy' => [ | |||
There was a problem hiding this comment.
- Spaces must be used for alignment; tabs are not allowed
- Line indented incorrectly; expected at least 20 spaces, found 12
| @@ -157,6 +156,15 @@ | |||
| ), | |||
| ), | |||
| ), | |||
| 'dataprivacy' => [ | |||
| 'type' => 'Literal', | |||
There was a problem hiding this comment.
- Spaces must be used for alignment; tabs are not allowed
- Line indented incorrectly; expected at least 20 spaces, found 16
| @@ -157,6 +156,15 @@ | |||
| ), | |||
| ), | |||
| ), | |||
| 'dataprivacy' => [ | |||
| 'type' => 'Literal', | |||
| 'options' => [ | |||
There was a problem hiding this comment.
- Spaces must be used for alignment; tabs are not allowed
- Line indented incorrectly; expected at least 20 spaces, found 12
| 'dataprivacy' => [ | ||
| 'type' => 'Literal', | ||
| 'options' => [ | ||
| 'route' => '/dataprivacy', |
There was a problem hiding this comment.
- Spaces must be used for alignment; tabs are not allowed
- Line indented incorrectly; expected at least 20 spaces, found 16
| 'type' => 'Literal', | ||
| 'options' => [ | ||
| 'route' => '/dataprivacy', | ||
| 'defaults' => [ |
There was a problem hiding this comment.
- Spaces must be used for alignment; tabs are not allowed
- Line indented incorrectly; expected at least 20 spaces, found 16
| 'options' => [ | ||
| 'route' => '/dataprivacy', | ||
| 'defaults' => [ | ||
| 'action' => 'dataprivacy', |
There was a problem hiding this comment.
Spaces must be used for alignment; tabs are not allowed
| 'route' => '/dataprivacy', | ||
| 'defaults' => [ | ||
| 'action' => 'dataprivacy', | ||
| ], |
There was a problem hiding this comment.
Spaces must be used for alignment; tabs are not allowed
| 'defaults' => [ | ||
| 'action' => 'dataprivacy', | ||
| ], | ||
| ], |
There was a problem hiding this comment.
Spaces must be used for alignment; tabs are not allowed
| 'action' => 'dataprivacy', | ||
| ], | ||
| ], | ||
| ], |
There was a problem hiding this comment.
Spaces must be used for alignment; tabs are not allowed
| 'options' => array( | ||
| 'route' => 'slack.php.ug', | ||
| 'defaults' => array( | ||
| '__NAMESPACE' => 'Phpug\Controller', |
There was a problem hiding this comment.
Spaces must be used for alignment; tabs are not allowed
| @@ -418,6 +448,10 @@ | |||
| 'label' => 'Legal', | |||
| 'route' => 'ug/legal', | |||
| ), | |||
| [ | |||
There was a problem hiding this comment.
- Spaces must be used for alignment; tabs are not allowed
- Line indented incorrectly; expected at least 12 spaces, found 8
| @@ -418,6 +448,10 @@ | |||
| 'label' => 'Legal', | |||
| 'route' => 'ug/legal', | |||
| ), | |||
| [ | |||
| 'label' => 'Data-Privacy', | |||
There was a problem hiding this comment.
Spaces must be used for alignment; tabs are not allowed
| @@ -418,6 +448,10 @@ | |||
| 'label' => 'Legal', | |||
| 'route' => 'ug/legal', | |||
| ), | |||
| [ | |||
| 'label' => 'Data-Privacy', | |||
| 'route' => 'ug/dataprivacy', | |||
There was a problem hiding this comment.
- Spaces must be used for alignment; tabs are not allowed
- Line indented incorrectly; expected at least 12 spaces, found 8
| [ | ||
| 'label' => 'Data-Privacy', | ||
| 'route' => 'ug/dataprivacy', | ||
| ], |
There was a problem hiding this comment.
Spaces must be used for alignment; tabs are not allowed
| @@ -111,6 +111,11 @@ public function legalAction() | |||
| return array(); | |||
| } | |||
|
|
|||
| public function dataprivacyAction() | |||
| { | |||
| return []; | |||
There was a problem hiding this comment.
- Spaces must be used to indent lines; tabs are not allowed
- Line indented incorrectly; expected at least 8 spaces, found 4
| @@ -120,7 +125,11 @@ public function redirectAction() | |||
| { | |||
| $id = $this->getEvent()->getRouteMatch()->getParam('ugid'); | |||
| $base = $this->getEvent()->getRouteMatch()->getParam('base'); | |||
|
|
|||
| if ($id === 'slack') { | |||
There was a problem hiding this comment.
Spaces must be used to indent lines; tabs are not allowed
| @@ -120,7 +125,11 @@ public function redirectAction() | |||
| { | |||
| $id = $this->getEvent()->getRouteMatch()->getParam('ugid'); | |||
| $base = $this->getEvent()->getRouteMatch()->getParam('base'); | |||
|
|
|||
| if ($id === 'slack') { | |||
| $this->redirect()->toUrl('https://phpug.slack.com'); | |||
There was a problem hiding this comment.
- Spaces must be used to indent lines; tabs are not allowed
- Line indented incorrectly; expected at least 12 spaces, found 8
|
|
||
| if ($id === 'slack') { | ||
| $this->redirect()->toUrl('https://phpug.slack.com'); | ||
| return; |
There was a problem hiding this comment.
- Spaces must be used to indent lines; tabs are not allowed
- Line indented incorrectly; expected at least 12 spaces, found 8
| if ($id === 'slack') { | ||
| $this->redirect()->toUrl('https://phpug.slack.com'); | ||
| return; | ||
| } |
There was a problem hiding this comment.
- Spaces must be used to indent lines; tabs are not allowed
- Line indented incorrectly; expected 8 spaces, found 4
- Closing brace indented incorrectly; expected 8 spaces, found 4
- Whitespace found at end of line
| use Zend\Form\Form; | ||
| use Zend\Permissions\Acl\Acl; | ||
| use Zend\Mvc\Controller\AbstractActionController; | ||
| use Doctrine\ORM\EntityManager; |
There was a problem hiding this comment.
There must be one blank line after the last USE statement; 2 found;
| ]; | ||
|
|
||
| $response = $this->client->request( | ||
| 'POST', |
There was a problem hiding this comment.
Multi-line function call not indented correctly; expected 16 spaces but found 17
|
|
||
| $response = $this->client->request( | ||
| 'POST', | ||
| 'https://'.$this->teamName.'.slack.com/api/users.admin.invite', |
There was a problem hiding this comment.
Multi-line function call not indented correctly; expected 16 spaces but found 17
| } | ||
|
|
||
|
|
||
| } catch(Exception $e){ |
There was a problem hiding this comment.
- Expected 1 space after CATCH keyword; 0 found
- Expected 1 space after closing parenthesis; found 0
| <?php | ||
| /** | ||
| * Copyright (c)2013-2013 heiglandreas | ||
| * |
| * | ||
| * The above copyright notice and this permission notice shall be included in | ||
| * all copies or substantial portions of the Software. | ||
| * |
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| * THE SOFTWARE. | ||
| * | ||
| * @category |
| <?php | ||
| /** | ||
| * Copyright (c)2013-2013 heiglandreas | ||
| * |
| * | ||
| * The above copyright notice and this permission notice shall be included in | ||
| * all copies or substantial portions of the Software. | ||
| * |
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| * THE SOFTWARE. | ||
| * | ||
| * @category |
| use Zend\Stdlib\Hydrator\ClassMethods; | ||
| use Zend\Validator; | ||
| use DoctrineModule\Stdlib\Hydrator\DoctrineObject; | ||
| use Phpug\Entity\Usergroup; |
There was a problem hiding this comment.
There must be one blank line after the last USE statement; 2 found;
| use Phpug\Entity\Usergroup; | ||
|
|
||
|
|
||
| class SlackInviteFormFactory implements FactoryInterface |
There was a problem hiding this comment.
Expected 1 space before FactoryInterface; 2 found
|
|
||
| return $form; | ||
| } | ||
| } |
There was a problem hiding this comment.
- Expected 1 newline at end of file; 0 found
- Line indented incorrectly; expected 0 spaces, found 1
- Closing brace indented incorrectly; expected 0 spaces, found 1
| use Phpug\Entity\Usergroup; | ||
|
|
||
|
|
||
| class SlackInviteFormFactory implements FactoryInterface |
There was a problem hiding this comment.
Expected 1 space before FactoryInterface; 2 found
|
|
||
| return $form; | ||
| } | ||
| } |
There was a problem hiding this comment.
- Expected 1 newline at end of file; 0 found
- Line indented incorrectly; expected 0 spaces, found 1
- Closing brace indented incorrectly; expected 0 spaces, found 1
heiglandreas
force-pushed
the
currentlive
branch
from
035f024 to
8601811
Compare
src/module/Phpug/Module.php
Outdated
| $sharedManager->attach( | ||
| 'Zend\Mvc\Controller\AbstractActionController', | ||
| 'dispatch', | ||
| function($e) use ($sm) { |
There was a problem hiding this comment.
Expected 1 space after FUNCTION keyword; 0 found
| @@ -66,22 +74,25 @@ public function getList() | |||
| if (! isset($result[$twitter->getName()])) { | |||
| $result[$twitter->getName()] = array( | |||
| 'screen_name' => $twitter->getName(), | |||
| 'name' => $twitterService->getInfoForUser('name', | |||
| 'name' => $this->twitter->getInfoForUser('name', | |||
There was a problem hiding this comment.
Opening parenthesis of a multi-line function call must be the last content on the line
| $twitter->getName()), | ||
| 'url' => $twitter->getUrl(), | ||
| 'icon_url' => $twitterService->getInfoForUser('profile_image_url_https', | ||
| 'icon_url' => $this->twitter->getInfoForUser('profile_image_url_https', |
There was a problem hiding this comment.
Opening parenthesis of a multi-line function call must be the last content on the line
| $groupMapUrl = $this->url()->fromRoute( | ||
| 'home', | ||
| array(), | ||
| array('force_canonical' => true)) . '?center=' . $group->getShortName(); |
There was a problem hiding this comment.
- Multi-line function call not indented correctly; expected 16 spaces but found 20
- Closing parenthesis of a multi-line function call must be on a line by itself
due to some changes in depending libraries up to this commit it was not possible to get a local instance up and running…
heiglandreas
force-pushed
the
currentlive
branch
from
8601811 to
ff09759
Compare
No description provided.