Skip to content

Allow installation with symfony 6.* #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Allow installation with symfony 6.* #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e99b34c
fix tests on windows
May 2, 2022
28b3118
update psr/cache and php-cs-fixer to allow usage of symfony 6 packages
May 2, 2022
17444c7
allow symfony/event-dispatcher >=6
May 2, 2022
1565177
remove unwanted plugin config
May 2, 2022
c77677e
allow simple-cache versions 2 and 3
May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@
"require": {
"php": "^7.3 || ^7.4 || ^8.0",
"ext-json": "*",
"symfony/options-resolver": ">=4.4,<6",
"psr/cache": "^1.0",
"psr/simple-cache": "^1.0",
"symfony/options-resolver": ">=4.4",
"psr/cache": "^1.0 || ^2.0 || ^3.0",
"psr/simple-cache": "^1.0 || ^2.0 || ^3.0",
"psr/event-dispatcher": "^1.0",
"psr/event-dispatcher-implementation": "^1.0",
"psr/log": "^1.0 || ^2.0 || ^3.0",
Expand All @@ -48,12 +48,12 @@
},
"require-dev": {
"nyholm/psr7": "^1.2",
"friendsofphp/php-cs-fixer": "^2.17",
"friendsofphp/php-cs-fixer": ">2.17",
"php-http/mock-client": "^1.2",
"slevomat/coding-standard": "^6.4.1",
"squizlabs/php_codesniffer": "^3.5.8",
"symfony/cache": ">=4.4,<6",
"symfony/event-dispatcher": "^5.0,<6",
"symfony/cache": ">=4.4",
"symfony/event-dispatcher": ">=5.0",
"phpstan/phpstan": "^0.12.18",
"phpunit/phpunit": "^7.5 || ^8.0 || ^9.3",
"php-http/guzzle7-adapter": "^0.1",
Expand Down
5 changes: 1 addition & 4 deletions test/Tmdb/Tests/Event/Listener/Logger/LogApiErrorListenerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,7 @@ public function shouldLogApiError()
$eventDispatcher->addListener(TmdbExceptionEvent::class, new LogApiErrorListener($logger));
$eventDispatcher->dispatch($event);

$expectedMessage = <<<EXCEPTION
Critical API exception:
7 invalid api key
EXCEPTION;
$expectedMessage = "Critical API exception:" . PHP_EOL . "7 invalid api key";

$this->assertCount(1, $logger->getLogCalls());
$this->assertSame([$expectedMessage], $logger->getLogCalls()->getMessages());
Expand Down
15 changes: 3 additions & 12 deletions test/Tmdb/Tests/Event/Listener/Logger/LogHttpMessageListenerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,7 @@ public function shouldLogRequest()
);
$eventDispatcher->dispatch($event);

$expectedMessage = <<<HEADER
Sending request:
GET http://www.test.com/foo/bar 1.1
HEADER;
$expectedMessage = "Sending request:" . PHP_EOL . "GET http://www.test.com/foo/bar 1.1";

$this->assertCount(1, $logger->getLogCalls());
$this->assertSame([$expectedMessage], $logger->getLogCalls()->getMessages());
Expand Down Expand Up @@ -84,10 +81,7 @@ public function shouldLogResponse()
);
$eventDispatcher->dispatch($event);

$expectedMessage = <<<HEADER
Received response:
200 OK 1.1
HEADER;
$expectedMessage = "Received response:" . PHP_EOL . "200 OK 1.1";

$this->assertCount(1, $logger->getLogCalls());
$this->assertSame([$expectedMessage], $logger->getLogCalls()->getMessages());
Expand All @@ -111,10 +105,7 @@ public function shouldLogClientException()
);
$eventDispatcher->dispatch(new HttpClientExceptionEvent($exception, $request));

$expectedMessage = <<<HEADER
Critical http client error:
0 connection exception
HEADER;
$expectedMessage = "Critical http client error:" . PHP_EOL . "0 connection exception";

$this->assertCount(1, $logger->getLogCalls());
$this->assertSame([$expectedMessage], $logger->getLogCalls()->getMessages());
Expand Down