Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: improve documentation #80

Merged
merged 2 commits into from
Dec 16, 2021

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Dec 12, 2021

README: update recommended excludes

By default the .git directory will also be scanned forPHP files and as it often contains a lot of directories, this can really slow down the run time for the linting.

By adding an exclude for the .git directory in the Symfony example, this will hopefully help people realize that excluding the .git directory is a good idea.

README: document inline minimum version definition option

To be honest, I never realized this was possible until I looked at the code in more detail, so I have a feeling that this feature is barely known.

This feature has been in the codebase since 2014 (b0b05d2), so let's document this option to raise awareness

By default the `.git` directory will also be scanned forPHP files and as it often contains a lot of directories, this can really slow down the run time for the linting.

By adding an exclude for the `.git` directory in the Symfony example, this will hopefully help people realize that excluding the `.git` directory is a good idea.
To be honest, I never realized this was possible until I looked at the code in more detail, so I have a feeling that this feature is barely known.

This feature has been in the codebase since 2014 (b0b05d2), so let's document this option to raise awareness.
@jrfnl jrfnl requested a review from grogy December 12, 2021 03:30
@grogy
Copy link
Member

grogy commented Dec 16, 2021

I forget to the feature with ignore lint in file

Thanks for the MR :-)

@grogy grogy merged commit d4798fb into master Dec 16, 2021
@grogy grogy deleted the feature/readme-document-inline-exclude-feature branch December 16, 2021 06:25
@jrfnl jrfnl added this to the 1.x Next milestone Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants