Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH Actions: various improvements to the workflows #76

Merged
merged 4 commits into from
Dec 6, 2021
Merged

GH Actions: various improvements to the workflows #76

merged 4 commits into from
Dec 6, 2021

Commits on Dec 1, 2021

  1. GH Actions: add ini settings to "release" workflow 

    Follow-up on PR 65, which turned set `error_reporting` to `E_ALL` and turned `display_errors` on in the Test workflow.

Only just now noticed that I missed doing the same in the Release workflow.

This also changes the setting for `error_reporting` to `-1` as `E_ALL` does not contain **all** errors across PHP versions, while `-1` will show them, independently of the PHP version.

Also turning on assertions, just in case they are used under the hood in the test framework.
    @jrfnl
    jrfnl committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    5a27329 View commit details
    Browse the repository at this point in the history

  2. GH Actions: minor simplification 

    No need for the `experimental` key, we can just refer directly to the `matrix.php` version in the `continue-on-error` condition.
    @jrfnl
    jrfnl committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    77f93f1 View commit details
    Browse the repository at this point in the history

  3. GH Actions: don't run the release workflow on forks 

    Just in case someone would push a tag up to their own fork.
    @jrfnl
    jrfnl committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    fdfaa28 View commit details
    Browse the repository at this point in the history

  4. GH Actions: auto-cancel previous builds for same branch 

    Previously, in Travis, when the same branch was pushed again and the "Auto cancellation" option on the "Settings" page had been turned on (as it was for most repos), any still running builds for the same branch would be stopped in favour of starting the build for the newly pushed version of the branch.

To enable this behaviour in GH Actions, a `concurrency` configuration needs to be added to each workflow for which this should applied to.

More than anything, this is a way to be kind to GitHub by not wasting resources which they so kindly provide to us for free.

Refs:
* https://github.blog/changelog/2021-04-19-github-actions-limit-workflow-run-or-job-concurrency/
* https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#concurrency
    @jrfnl
    jrfnl committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    8b30b69 View commit details
    Browse the repository at this point in the history