Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat changelog to use reflinks in changelog entries #58

Merged
merged 1 commit into from
May 5, 2021

Conversation

glensc
Copy link

@glensc glensc commented Apr 7, 2021

See discussion at #57

Copy link
Collaborator

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner!

Mind: there is one gotcha - when creating a new release and copying the changelog to it, the links to the contributor pages at the bottom of the file will also need to be copied over to the release text.

Just something to be aware of once this PR has been merged.

@mfn
Copy link

mfn commented Apr 7, 2021

Mind: there is one gotcha - when creating a new release and copying the changelog to it, the links to the contributor pages at the bottom of the file will also need to be copied over to the release text.

I think that for that very reason, this change, especially on the changelog, should not be done:

  • for the readability of the file aka rendered for the end user: it does not matter
  • for maintainers, on a release, it creates additional work => ideally you just copypaste this block to the release page and be done, not fiddle around with links
  • (I would argue it's also slightly more maintenance work on a regular basis: adding self-container blocks of markup feels more natural than having to split them up for links)

@glensc
Copy link
Author

glensc commented Apr 7, 2021

@jrfnl no, you don't. GitHub formats issues/pull-requests and usernames anyway, without markdown magic required. this is needed only when you want to render the changelog in view file or outside github.

@glensc
Copy link
Author

glensc commented Apr 7, 2021

@mfn I very strongly disagree, changelog must be readable without a full bloated browser. the changelog is edited by humans, humans make mistakes, if each entry is 300 bytes long, they don't grasp anymore the noise from the data. so copying a wrong username or ticket link is very easy to make.

and another opinion, maintaining a changelog file is a band-aid of lacking automation that could take pull requests, issues, and their titles, labels and combine up a release note and generate that release notes on release creation.

@mfn
Copy link

mfn commented Apr 7, 2021

@glensc

Good points, we've different opinions 👍

and another opinion, maintaining a changelog file is a band-aid of lacking automation that could take pull requests, issues, and their titles, labels and combine up a release note and generate that release notes on release creation.

Agree!

Unfortunately so far I've only seen tools that take literally every commit/PR and add them, making an unreadable mess of things 😢

@glensc
Copy link
Author

glensc commented Apr 8, 2021

@mfn no, commits are too granular, and you can't edit them prior to release. but pull requests title, and their labels are a very good fit. you can edit (as a maintainer) them prior to release, and classify each pr/issue of change type.

this idea is so trivial, and yet I have not found a good project to automate this all.

the closest I've come acquainted with is:

anyway, the downside of the release notes manual task topic mentioned here does not apply at all.

here's some older release, using @userhandle and #issue/#pr that need no special formatting:

  1. rendered: https://github.com/eventum/eventum/releases/tag/v3.5.6
  2. source:
    image

@glensc
Copy link
Author

glensc commented Apr 19, 2021

@grogy ping. this pr is a response to your wish:

@grogy
Copy link
Member

grogy commented May 5, 2021

Thanks! It look's too better

@grogy grogy merged commit 8b8a59a into php-parallel-lint:master May 5, 2021
@glensc glensc deleted the changelog branch May 10, 2021 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants