Extend by the Code Climate output format #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any information missing or does the pull request not match your requirements? |
|
For the first look it is ok. I will try on any project and is possible to merge it |
grogy
requested changes
Mar 30, 2021
The Code Climate format is used in the GitLab CI/CD to show errors in the merge request page. The simple JSON format is not sufficient for this.
|
Does the test |
|
PR #45 need more time from me, so i merged this. Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, we use this linter in our PHP projects. We have our repositories in GitLab and use the CI pipeline there. When we run the CI pipeline, we run QA tools. When the pipeline is executed, we want GitLab to load the errors from a json file and display them in the merge request. This should make it easier to see which bugs have been added and which have been fixed.
For this we use the Code Quality widget. This requires creating a Json file that implements a subset of the code-climate specification.
With this merge request I suggest that this linter supports this format so that not every CI pipeline has to use a converter.
We also use PHPStan, they support this format.
PHP_CodeSniffer do not support the format, but they offer the possibility to include external reports/formats. I have not discovered this possibility in this linter. We strongly want to avoid using a fork for this feature, so I made this merge request.
Sorry for bothering you with this issue.