Ignore PHP startup errors #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix issue 33, by ignoring PHP startup errors completely for any PHP processes started from within the application.
Seldaek
approved these changes
May 23, 2020
|
@grogy Anything I can do to move this PR forward ? |
|
@grogy Any chance of this PR getting some love ? |
|
I read previous thread #33 and current I think about it is good thing in project. Maybe it make the sence.. please, take me a few days for it. Idea - is good when tool does second thing - silence warnings? |
|
My thinking about this change takes long. I am sorry, but I cannot merge everything that will be created in PRs. It makes sense to me. Reason - directive Thank you @Seldaek for define problem and @jrfnl for implementation and kick me for resolve PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignoring PHP startup errors completely for any PHP processes started from within the application.
Fixes #33