Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OutputTest: fix risky test #156

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Mar 16, 2024

The OutputTest::testGitLabOutput() was being marked as risky for the first test case (no errors) as no assertions were being run.

This commit adds an extra assertion to prevent this, but also to make the test more thorough as the test will now also fail if the number of errors expected versus received does not match.

@jrfnl jrfnl added this to the 2.0.0 milestone Mar 16, 2024
@jrfnl jrfnl requested a review from grogy March 16, 2024 21:06
@jrfnl jrfnl modified the milestones: 2.0.0, 1.3.x Next Mar 16, 2024
The `OutputTest::testGitLabOutput()` was being marked as risky for the first test case (no errors) as no assertions were being run.

This commit adds an extra assertion to prevent this, but also to make the test more thorough as the test will now also fail if the number of errors expected versus received does not match.
@jrfnl jrfnl force-pushed the feature/tests-fix-risky-test branch from 0da1c90 to 35623bb Compare March 27, 2024 10:38
Copy link
Member

@grogy grogy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it makes sense. It will be safer.

@grogy grogy merged commit ea852b5 into php-parallel-lint:develop Mar 27, 2024
16 of 17 checks passed
@jrfnl jrfnl deleted the feature/tests-fix-risky-test branch March 27, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants