Skip to content

Commit

Permalink
GH Actions: set error reporting to E_ALL
Browse files Browse the repository at this point in the history
Turns out the default setting for `error_reporting` used by the SetupPHP action is `error_reporting=E_ALL & ~E_DEPRECATED & ~E_STRICT` and `display_errors` is set to `Off`.

For the purposes of CI, I'd recommend running with `E_ALL` and `display_errors=On` to ensure **all** PHP notices are shown.
  • Loading branch information
jrfnl authored and grogy committed Aug 13, 2021
1 parent 761f380 commit e80d321
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
php-version: 5.4
extensions: exif, phar, openssl
coverage: none
ini-values: phar.readonly=Off
ini-values: phar.readonly=Off, error_reporting=E_ALL, display_errors=On

- name: Install Box from GitHub
run: |
Expand Down Expand Up @@ -106,6 +106,7 @@ jobs:
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php }}
ini-values: error_reporting=E_ALL, display_errors=On
coverage: none

# Remove PHPCS as it has a minimum PHP requirements of PHP 5.4 and would block install on PHP 5.3.
Expand Down

0 comments on commit e80d321

Please sign in to comment.