-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added small script to test installation on with different dependencies #157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, good idea!
can we improve output of the build? its rather cryptic now to see what is not working. and do you plan on adding the fix in this PR too?
echo -e "\\e[41mKO\\e[0m $title\\n" | ||
(exit $ok) | ||
} | ||
export -f install_test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we add this as a bash file to tests folder, or .travis
folder? no big deal, but it seems a bit much for the travis configuration file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think so. Im not sure how you can "export" a function in bash/travis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah i see, bash function, not bash script. i guess thats fine then. maybe bash source
-ing the file would work, but i will merge as is and tag another patch release
Sure, I added a commit with a fix for #156 |
What do you suggest?
|
i somehow expected something before the error line, but the last line is enough. as it should normally not fail, it will at least indicate when something is amiss. |
Thank you for merging |
This is a small script to make sure we test different sets of configuration. Related to #156
Test should fail because #156 describes a problem.