Refactor to remove "guzzle specific" logic (#177)

php-http · Jul 2, 2020 · a6bce7a · a6bce7a
1 parent fef8475
commit a6bce7a
Showing 1 changed file with 7 additions and 13 deletions.
diff --git a/src/Strategy/CommonClassesStrategy.php b/src/Strategy/CommonClassesStrategy.php
@@ -98,7 +98,7 @@ final class CommonClassesStrategy implements DiscoveryStrategy
             ],
             [
                 'class' => GuzzleHttp::class,
-                'condition' => GuzzleHttp::class,
+                'condition' => [self::class, 'isGuzzleImplementingPsr18'],
             ],
             [
                 'class' => [self::class, 'buzzInstantiate'],
@@ -125,18 +125,7 @@ public static function getCandidates($type)
      */
     private static function getPsr18Candidates()
     {
-        $candidates = [];
-
-        // Guzzle 6 does not implement the PSR-18 client interface, but Guzzle 7 does.
-        foreach (self::$classes[Psr18Client::class] ?? [] as $c) {
-            if (GuzzleHttp::class === $c['class']) {
-                if (defined('GuzzleHttp\ClientInterface::MAJOR_VERSION')) {
-                    $candidates[] = $c;
-                }
-            } else {
-                $candidates[] = $c;
-            }
-        }
+        $candidates = self::$classes[Psr18Client::class];
 
         // HTTPlug 2.0 clients implements PSR18Client too.
         foreach (self::$classes[HttpClient::class] as $c) {
@@ -162,6 +151,11 @@ public static function symfonyPsr18Instantiate()
         return new SymfonyPsr18(null, Psr17FactoryDiscovery::findResponseFactory(), Psr17FactoryDiscovery::findStreamFactory());
     }
 
+    public static function isGuzzleImplementingPsr18()
+    {
+        return defined('GuzzleHttp\ClientInterface::MAJOR_VERSION');
+    }
+
     /**
      * Can be used as a condition.
      *