Sending Content-Length: 0 is optional for TRACE #33
Conversation
src/HttpBaseTest.php
Outdated
| @@ -270,6 +270,10 @@ protected function assertRequest( | |||
|
|
|||
| $name = strtoupper(str_replace('-', '_', 'http-'.$name)); | |||
|
|
|||
| if ($method === 'TRACE' && $name === 'HTTP_CONTENT_LENGTH' && !isset($request['SERVER'][$name])) { | |||
| $request['SERVER'][$name] = '0'; | |||
There was a problem hiding this comment.
so we add a fake content length? while this works, i would prefer to simply log a $this->success() and return instead. the assertions below make no sense if we just set the value.
i agree that if content length is set, it must be correctly at 0.
There was a problem hiding this comment.
That makes everything more complicated. The test correctly asserts that there's a content-length: 0 or no header at all. While this specific assertion might be useless then, there are always non-useless assertions.
There was a problem hiding this comment.
but you could replace this line by return; and the test would still do the same, right? i would find that more readable.
There was a problem hiding this comment.
No, but can replace it with continue;, just did that.
There was a problem hiding this comment.
ups, did not read the context :-)
|
All tests passes. Thank you! |
What's in this PR?
As no body is allowed, the
content-lengthheader is optional.