Skip to content

Recommend omitting wrapping parenthesis when immediately calling a method on a new instance #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crell merged 2 commits into from
Mar 26, 2025
Merged

Recommend omitting wrapping parenthesis when immediately calling a method on a new instance #110

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdbf3ee
Recommend omitting wrapping parenthesis when immediately calling a me…
KorvinSzanto Jan 21, 2025
e851630
Make it clear that this applies when accessing any class member and n…
KorvinSzanto Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,23 @@ separated by a space. For example:
class MyException extends \RuntimeException {}
```

When accessing a class member immeditely after instantiating a new class, the instantiation SHOULD NOT be wrapped in
Copy link
Contributor

@devfrey devfrey Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a small typo here, should be "immediately".

Copy link
Collaborator

@Crell Crell Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh. Since it's already merged, can you send a tiny PR? (I'm about to get on a plane.)

Copy link
Contributor

@devfrey devfrey Mar 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! #112

parenthesis. For example:

```php
new Foo()->someMethod();
new Foo()->someStaticMethod();
new Foo()->someProperty;
new Foo()::someStaticProperty;
new Foo()::SOME_CONSTANT;
```

And the following SHOULD be avoided:

```php
(new Foo())->someMethod();
```

### 4.1 Extends and Implements

The `extends` and `implements` keywords MUST be declared on the same line as
Expand Down