SlackNotify plugin kills worker process with error

[benr77]

Expected behavior

The worker process does not die when the build with slack_notify completes

Actual behavior

I see the following error when the build completes, as it tries to notify slack as per the slack notify plugin.

Error: Class 'Maknz\Slack\Client' not found (uncaught exception) at /var/www/app/src/Plugin/SlackNotify.php line 86

I'm using Docker, and this kills off the worker container completely, meaning it has to be restarted before any further builds can be processed.

Slack notify config:

    slack_notify:
        webhook_url: 'https://hooks.slack.com/services/xxxxxxxxxxxxxxxxxxx
        room: '#phpcensor'
        username: 'PHPCensor'
        icon: ':ghost:'
        message: '%PROJECT_TITLE% - build %BUILD% completed'
        show_status: true

Steps to reproduce

Just add that config to a build and the error should appear.

Presumably this is just a missing dependency in the composer.json

Environment

• PHP Censor 0.24
• Docker
• 7.2
• MySQL

[benr77]

Confirmed - all is fixed when I execute composer require maknz/slack

[corpsee]

@benr77 Yes, it is normal behavior if you don't install maknz/slack dependency. See documentation for plugin.

[garas]

@corpsee I'm using this Slack plugin too. As I'm using PHP Censor as git clone, I often find problem with git pull, because composer.json and composer.lock is modified after composer require maknz/slack.

I suggest to move those 3 packages from suggest to require and always install. This won't be noticeable in size as PHP Censor already has many dependencies.

    "suggest": {
        "maknz/slack":         "For SlackNotify plugin",
        "hipchat/hipchat-php": "For HipchatNotify plugin",
        "mremi/flowdock":      "For FlowdockNotify plugin"
    },

[corpsee]

@garas May be it will be good solution. Thanks.

[benr77]

Yes, apologies for not reading the documentation properly. I've migrated from PHPCI where this is not an optional dependency, you can just add the configuration and go!

[corpsee]

Depends on mremi/Flowdock#5, mremi/Flowdock#8, mremi/Flowdock#7