Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible blocking connection even when connection_timeout is specified #804

Closed
langemeijer opened this issue Jun 25, 2020 · 0 comments · Fixed by #812
Closed

Possible blocking connection even when connection_timeout is specified #804

langemeijer opened this issue Jun 25, 2020 · 0 comments · Fixed by #812
Assignees
Labels
Milestone

Comments

@langemeijer
Copy link

In AbstractConnection::x_open()

the line

return $this->wait($wait)

should read:

$this->wait($wait,false,$this->connection_timeout);

Calling without timeout can cause an indefinite blocking connection. It is an edge-case, because two earlier wait() calls succeded, but it is still possible. (and will happen in race-condition situations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants