Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds support for list of RoleContentMessages in phospho.log input and output #1252

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

oulianov
Copy link
Collaborator

@oulianov oulianov commented Oct 25, 2024

Summary

Situation before

Logging a list of {role:, content:} messages resulted in logging a string

What's here now

  • phospho.log supports lists in input, output
  • The list has heuristics to support system prompt, multiple user messages, multiple assistant messages
  • Tests run on 3.13

Check list

  • typing, linting, docstrings (cicd will fail)
  • If adding an external service, include the relevant API keys in deployment scripts in .github/workflows (staging and prod) and GH actions
  • If changing data models in phospho-python that are used in the backend, run poetry lock in phospho-python so the backend tests CICD cache is invalidated
  • If creating an API endpoint, add it to v3 so that you can easily document it in docs.phospho.ai

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
phospho-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 10:13am

@oulianov oulianov changed the title feat: Adds support for list of RoleContentMessages in phospho.log feat: Adds support for list of RoleContentMessages in phospho.log input and output Oct 25, 2024
@oulianov oulianov merged commit 6a51a44 into dev Oct 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant