raise if helpers called from #initialize #228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vagab
commented
Sep 14, 2024
| return super unless ActiveRecord::Relation === renderable | ||
| when nil | ||
| partial = kwargs.delete(:partial) | ||
| when Phlex::SGML, Proc, Method, String |
There was a problem hiding this comment.
I ran rubocop -A here. Let me know if I should roll this change back
Vagab
commented
Sep 14, 2024
| def helpers | ||
| raise HelpersCalledBeforeRenderError.new("Do not use rails helpers until after the view has been rendered.") unless @_view_context |
There was a problem hiding this comment.
alternatively I think we could move this to helper_macros.rb. But I think it's better to leave it here. Wdyt?
|
@joeldrapper ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #220