Add support for cargo binstall #236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello i think it work i try with the command and it seem to works
cargo binstall --pkg-url="{ repo }/releases/download/{ version }/{ name }-{ version }-{ target }.{ archive-format }"--pkg-fmt="txz" ripgrep_all
lafrenierejm
reviewed
Sep 3, 2024
Comment on lines
+74
to
+76
| [package.metadata.binstall] | ||
| pkg-url = "{ repo }/releases/download/{ version }/{ name }-{ version }-{ target }.{ archive-format }" | ||
| pkg-fmt = "tgz" |
There was a problem hiding this comment.
@yodatak Have you tried running binstall without these lines? Based on my reading of the binstall docs it seems like this configuration is all covered by binstall's defaults…
|
tbh I'm not sure whether we should "support" rg and afaik many other rust programs does not support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello i think it work i try with the command and it seem to works