stripphpcomments matches links in html (Trac #1219)

[phing-issues-importer]

<stripphpcomments> matches "https://www.infonline.de" (see attachment) as comment an removes the line after "https:".

Migrated from https://www.phing.info/trac/ticket/1219

{
    "status": "new", 
    "changetime": "2016-09-14T19:32:54", 
    "description": "{{{<stripphpcomments>}}} matches \"https://www.infonline.de\" (see attachment) as comment an removes the line after \"https:\".\n", 
    "reporter": "[email protected]", 
    "cc": "", 
    "resolution": "", 
    "_ts": "1473881574376244", 
    "component": "phing-core", 
    "summary": "stripphpcomments matches links in html", 
    "priority": "major", 
    "keywords": "", 
    "version": "2.12.0", 
    "time": "2015-09-23T22:10:04", 
    "milestone": "2.16.0", 
    "owner": "mrook", 
    "type": "defect"
}

[phing-issues-importer]

Trac update at 20150923T22:11:51: [email protected] changed attachment from "" to "bug.zip"

[phing-issues-importer]

Trac update at 20150923T22:42:54: [email protected] commented:

Temporary fix: in StripPhpComments.php

change

 '/\/\*[^*]*\*+([^\/*][^*]*\*+)*\/|\/\/[^\n]*|("(\\\\.|[^"\\\\])*"|\'(\\\\.|[^\'\\\\])*\'|.[^\/"\'\\\\]*)/s',

to

'/\/\*[^*]*\*+([^\/*][^*]*\*+)*\/|(?<!:)\/\/[^\n]*|("(\\\\.|[^"\\\\])*"|\'(\\\\.|[^\'\\\\])*\'|.[^\/"\'\\\\]*)/s',

I added (?<!:). But this is possibly a bad fix.

[phing-issues-importer]

Trac update at 20151204T10:17:36:

• mrook changed milestone from "Backlog" to "2.14.0"
• mrook changed priority from "critical" to "major"

[phing-issues-importer]

Trac update at 20160130T20:38:02: Michiel Rook commented:

Refs #579 - add test for stripphpcomments, strip shell-style comments
Changeset: 20ab0f8

[phing-issues-importer]

Trac update at 20160130T20:38:04: Michiel Rook commented:

Refs #579 - add test for stripphpcomments, strip shell-style comments
Changeset: 20ab0f8

[phing-issues-importer]

Trac update at 20160310T21:28:25:

• mrook commented:

Ticket retargeted after milestone closed

• mrook changed milestone from "2.14.0" to "2.15.0"

[phing-issues-importer]

Trac update at 20160914T19:32:54:

• mrook commented:

Ticket retargeted after milestone closed

• mrook changed milestone from "2.15.0" to "2.16.0"