fix resultscene button #261
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihoronir
force-pushed
the
feature/fix_resultscene_button
branch
from
5d202f3 to
8f4e6c9
Compare
|
やはり phina.ui.Button を使った方がシンプルに実装できるので、2年前の私のこの Shape を用いた実装はあまり良くないなと思いました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
先日見かけたツイートで、リザルトシーンのボタンの表示が環境によってはかっこ悪くなってしまうケースがあると分かったので、Shape を使った実装にしました。
↓こういう見た目に変わります。
ついでにリファクタもしました。