fix phina.util.Color #223
Open
fix phina.util.Color #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shioleap カラーリスト増えてるw
これは迷いどころですね. |
|
個人的には |
simiraaaa
reviewed
Dec 6, 2017
src/util/color.js
Outdated
| this.a = (a !== undefined) ? a : 1.0; | ||
| this.r = (r === 0) ? 0 : r || this.r; | ||
| this.g = (g === 0) ? 0 : g || this.g; | ||
| this.b = (b === 0) ? 0 : b || this.g; |
There was a problem hiding this comment.
(b === 0) ? 0 : b || this.g;ここthis.bですね
|
@simiraaaa さんにご指摘いただいたtypo修正いたしました！ |
|
@shioleap LGTM @phi-jp 自分はこれで問題ないと思います。 |
ihoronir
force-pushed
the
feature/fix-phina-util-color
branch
from
ffce78e to
8359d90
Compare
|
rebaseしました |
ihoronir
force-pushed
the
feature/fix-phina-util-color
branch
from
8359d90 to
04fee02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更点
setFromString()やsetSmartでhslaがうまく動かないのを修正setSmart()で数値からr,g,bを指定できないバグを修正set(),setFromNumber()の仕様変更setFromNumber()を使用しているメソッドの仕様も変更r,g,b,aを変えないようにした。r,b,gがnullになるのを防ぐことができる。setFromObject()では任意の値だけ変更できて便利HSLtoRGB()でs===0だったときに[0, 0, 0]を返すように変更lではなくnに変更しました。createStyleRGBのバグを修正今後検討するべきだと思うこと
setFromString()で RGB など Alpha の情報がなかった場合、aを 1 にすべきか、元の状態のままにすべきか。set()ではaを省略してもaが1になることはないが、そのこととの整合性をどうするか。set()でもaが省略されたとき、1にリセットされる方が良い？それとも1にリセットされない方が良い？