fix shape render timing #211
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
superMethodはあまり速くないのであまり良い気はしませんね |
|
速度… |
|
PlainElementのdraw内に_draw等で抽象メソッド用意しておいて、そこで描画させるようにするとかが現状での最適実装かと思います |
axion014
force-pushed
the
axion014/rendertiming
branch
from
9f8d3c5 to
dcfcf5e
Compare
|
今実装よりはかなりスッキリしたと思います |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #170
superMethodで実装しています。このやり方に問題があるようなら、もう少し議論しましょう。