chore: Next major release #3552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@koendelaat @navdeepg2021 this PR is ready. Any comments / suggestions before I merge? |
|
|
ScottGuymer
previously approved these changes
Oct 26, 2023
…MI (#3437) Replaces Amazon lLnux 2 (default) by Amazon Linux 2023. Impact for anyone relying on the default setup provided by the module. --------- Co-authored-by: Niek Palm <[email protected]>
Change variables `runner_labels` and `runner_extra_labels` to type: `list[string]` to better represent the content Additionally: - [x] Automatic determine runner labels for multi runner based on label matchers - [x] Enable Terraform linting on all modules, including naming conventions - [x] Enable check annotations for linting errors - [x] Fix existing linting errors - [ ] Apply naming conventions within objects (not supported by [TFLint](terraform-linters/tflint#1310)) This PR is based on #3143 creaed by @koendelaat but now via a dedicate branch in this repository. --------- Co-authored-by: Koen de Laat <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
koendelaat
previously approved these changes
Oct 26, 2023
GuptaNavdeep1983
previously approved these changes
Oct 26, 2023
npalm
dismissed stale reviews from GuptaNavdeep1983, koendelaat, and ScottGuymer
The merge-base changed after approval.
ScottGuymer
previously approved these changes
Oct 27, 2023
npalm
dismissed
ScottGuymer’s stale review
The merge-base changed after approval.
ScottGuymer
previously approved these changes
Oct 27, 2023
npalm
dismissed
ScottGuymer’s stale review
The merge-base changed after approval.
GuptaNavdeep1983
previously approved these changes
Oct 27, 2023
npalm
dismissed
GuptaNavdeep1983’s stale review
The merge-base changed after approval.
GuptaNavdeep1983
approved these changes
Oct 27, 2023
GuptaNavdeep1983
approved these changes
Oct 27, 2023
ScottGuymer
approved these changes
Oct 27, 2023
GuptaNavdeep1983
approved these changes
Oct 27, 2023
npalm
pushed a commit
that referenced
this pull request
Oct 27, 2023
🤖 I have created a release *beep* *boop* --- ## [5.0.0](v4.7.0...v5.0.0) (2023-10-27) ### Migration directions See [PR](#3552) for migration directions. ### ⚠ BREAKING CHANGES * remove depcrecated input and output variables ([#3567](#3567)) * Change runner labels to list[string] and apply TFLint ([#3410](#3410)) * replace Amazon Linux 2 by Amazon Linux 2023 as default Linux AMI ([#3437](#3437)) ### Features * replace Amazon Linux 2 by Amazon Linux 2023 as default Linux AMI ([#3437](#3437)) ([35219f5](35219f5)) ### Bug Fixes * Change runner labels to list[string] and apply TFLint ([#3410](#3410)) ([0b398f2](0b398f2)) * remove depcrecated input and output variables ([#3567](#3567)) ([89c8575](89c8575)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Upcoming release 5.0.0
Breaking changes
Linux version updated to Amazon Linux 2023
PR: #3437
The default Linux version in the module is updated to Amazon Linux 2023.
Migrations
user_dataor pre / post install scripts could require an update.Runner Labels
PR: #3410
Change of variable type and add option to declare labels for multi runner twice.
Migrations
runner_extra_labelschanged from typestringtostring[]. Updaterunner_extra_labelsfrom"label1,label2"to["label1","label2"]labelMatchersand for the runner inrunner_config.runner_extra_labels. By default we merge the labels ifrunner_extra_labelsis not set. In most cases you can just removerunner_extra_labels.close #3553