KAFKA-14960: [Part I]TopicMetadataRequestManager Implementation#7
Merged
Merged
Conversation
philipnee
force-pushed
the
consumer-refactor-metadata-request-manager
branch
from
May 10, 2023 18:27
b7f2814 to
eef8a9f
Compare
lianetm
reviewed
May 10, 2023
lianetm
reviewed
May 10, 2023
lianetm
reviewed
May 10, 2023
lianetm
reviewed
May 10, 2023
lianetm
reviewed
May 10, 2023
lianetm
reviewed
May 10, 2023
lianetm
reviewed
May 10, 2023
lianetm
reviewed
May 10, 2023
kirktrue
requested changes
May 10, 2023
kirktrue
left a comment
kirktrue
left a comment
Collaborator
There was a problem hiding this comment.
I'd like to see how this plugs into the background thread and application event processor, specifically how it handles ensuring that duplicate API calls are handled appropriately.
Also, can we refactor TopicMetadataRequestManager and TopicMetadataFetcher so that they use the same core response handling logic?
philipnee
force-pushed
the
consumer-refactor-metadata-request-manager
branch
from
May 11, 2023 20:14
8ae018e to
8616b93
Compare
Owner
Author
Owner
Author
|
I think I ommitted kirk's comments: Working on them ... |
philipnee
force-pushed
the
consumer-refactor-metadata-request-manager
branch
from
May 12, 2023 20:11
8616b93 to
03ff808
Compare
philipnee
commented
May 22, 2023
Owner
Author
kirktrue
reviewed
May 30, 2023
kirktrue
left a comment
kirktrue
left a comment
Collaborator
There was a problem hiding this comment.
I think I'm getting lost with all of the futures and callbacks. I feel we may want to do some restructuring, renaming, or documenting to keep things straight.
Collaborator
There was a problem hiding this comment.
Can we add some JavaDoc? I'm not totally sure when to use this class vs. using the future from the UnsentRequest.
fix broken test Add tests and fix response handler cleaned up and addressed some of the comments from the PR wip wip Testing the impl Added tests MetadataRequestManager and refactor the callbacks Update MetadataRequestManager.java Create MetadataRequestManager.java
philipnee
force-pushed
the
consumer-refactor-metadata-request-manager
branch
from
June 1, 2023 17:43
90ed7de to
f09fd9a
Compare
Owner
Author
|
@kirktrue thanks for the review! Ready for another pass. Think I addressed your comments. |
lianetm
reviewed
Jun 1, 2023
kirktrue
approved these changes
Jun 8, 2023
philipnee
added a commit
that referenced
this pull request
Jun 9, 2023
TopicMetadataRequestManager implementation --------- Co-authored-by: Lianet Magrans <lmagrans@confluent.io>
kirktrue
added a commit
that referenced
this pull request
Jun 22, 2023
…o new consumer threading refactor This change introduces the FetchRequestManager that will be responsible for: - Formatting fetch requests to the background thread - Configuring the callback on fetch responses for the background thread The response handler will collect the fetch responses from the broker and create CompletedFetch instances as is done in Fetcher. The foreground logic will decompress the data into a Record, which will then be deserialized into a ConsumerRecord for returning to the user.
philipnee
added a commit
that referenced
this pull request
Jul 19, 2023
TopicMetadataRequestManager implementation --------- Co-authored-by: Lianet Magrans <lmagrans@confluent.io>
philipnee
added a commit
that referenced
this pull request
Sep 11, 2023
TopicMetadataRequestManager implementation --------- Co-authored-by: Lianet Magrans <lmagrans@confluent.io>
philipnee
added a commit
that referenced
this pull request
Sep 11, 2023
TopicMetadataRequestManager implementation --------- Co-authored-by: Lianet Magrans <lmagrans@confluent.io>
philipnee
added a commit
that referenced
this pull request
Sep 13, 2023
TopicMetadataRequestManager implementation --------- Co-authored-by: Lianet Magrans <lmagrans@confluent.io>
philipnee
added a commit
that referenced
this pull request
Sep 13, 2023
TopicMetadataRequestManager implementation --------- Co-authored-by: Lianet Magrans <lmagrans@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the implementation of the TopicMetadataRequestManager, responsible for handling topic metadata from
partitionsForandlistTopicsThe PR also refactors the current callback mechanism because I think the usage is rather inorganic. Now, user can pass in a BiConsumer to be triggered when the request is completed.
@kirktrue @lianetm