Skip to content

move from tsc to tsgo - #1033

Merged
philiplehmann merged 2 commits into
mainfrom
feature/tsc-to-tsgo
Apr 16, 2026
Merged

philiplehmann merged 2 commits into
mainfrom
feature/tsc-to-tsgo

Conversation

@philiplehmann

@philiplehmann philiplehmann commented Apr 16, 2026 •

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Chores
    • Updated development dependencies to use native TypeScript implementation for enhanced performance
    • Configured editor settings (VS Code and Zed) with experimental TypeScript features
    • Added optional tsgo type-checking mode for faster development builds
    • Simplified TypeScript configuration

- Add `@typescript/native-preview` dependency
- Add `tsgo` option to tsc typecheck executor and schema
- Update nx.json to enable tsgo for typecheck
- Update editor configs for tsgo support
- Remove typescript dependency from package.json
@coderabbitai

coderabbitai Bot commented Apr 16, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@philiplehmann has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 50 minutes and 23 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 50 minutes and 23 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: eab4140d-9caf-401b-9b20-e1bf82fdd8e7

📥 Commits

Reviewing files that changed from the base of the PR and between 7fc5dda and 979a9f1.

📒 Files selected for processing (13)
  • CHANGELOG.md
  • libs/biomejs/CHANGELOG.md
  • libs/biomejs/package.json
  • libs/bun/CHANGELOG.md
  • libs/bun/package.json
  • libs/docker/CHANGELOG.md
  • libs/docker/package.json
  • libs/node/CHANGELOG.md
  • libs/node/package.json
  • libs/nx/CHANGELOG.md
  • libs/nx/package.json
  • libs/tsc/CHANGELOG.md
  • libs/tsc/package.json
📝 Walkthrough

Walkthrough

This PR introduces support for tsgo, an alternative TypeScript implementation, across development environments and build tooling. Configuration is added for VS Code and Zed editors, the TypeScript executor is updated with conditional logic to use tsgo when enabled, and the typescript package dependency is replaced with @typescript/native-preview.

Changes

Cohort / File(s) Summary
Editor Configuration
.vscode/settings.json, .zed/settings.json
Added experimental tsgo setting in VS Code and configured TypeScript to use tsgo and vtsls language servers in Zed.
Executor & Schema
libs/tsc/src/executors/typecheck/executor.ts, libs/tsc/src/executors/typecheck/schema.d.ts, libs/tsc/src/executors/typecheck/schema.json
Updated executor to conditionally spawn tsgo or tsc based on a new tsgo boolean parameter; added corresponding schema definitions with descriptions.
Build & Dependency Configuration
nx.json, package.json, tsconfig.base.json
Added tsgo: true option to typecheck target defaults; replaced typescript 6.0.2 dependency with @typescript/native-preview 7.0.0-dev; removed baseUrl compiler option from TypeScript config.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Hop, hop, tsgo now runs free,
Swift as rabbits, quick as can be,
From Zed to VS Code's domain,
TypeScript reimagined, faster to maintain!
Native preview hops into place, ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main objective of the changeset, which is migrating from tsc to tsgo for type checking across configuration and executor files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/tsc-to-tsgo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
libs/tsc/src/executors/typecheck/executor.ts (1)

20-34: ⚠️ Potential issue | 🔴 Critical

Change the default tsgo parameter from false to true.

The executor defaults to spawning tsc on line 34, but the typescript package has been removed and replaced with @typescript/native-preview, which only provides the tsgo binary. All 13+ projects using the @riwi/tsc:typecheck executor with empty options will fail at runtime with "command not found: tsc".

Fix
-  { tsconfig = 'tsconfig.lib.json', tsgo = false },
+  { tsconfig = 'tsconfig.lib.json', tsgo = true },
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@libs/tsc/src/executors/typecheck/executor.ts` around lines 20 - 34, The
executor's default option sets tsgo = false causing promiseSpawn to call 'tsc'
by default; change the parameter default from tsgo = false to tsgo = true in the
executor signature so that promiseSpawn(...) uses 'tsgo' (refer to the parameter
in the destructured options and the call to promiseSpawn which currently chooses
between 'tsgo' and 'tsc'). Ensure no other logic needs changing and update any
related docstring/comments if present.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@libs/tsc/src/executors/typecheck/executor.ts`:
- Around line 20-34: The executor's default option sets tsgo = false causing
promiseSpawn to call 'tsc' by default; change the parameter default from tsgo =
false to tsgo = true in the executor signature so that promiseSpawn(...) uses
'tsgo' (refer to the parameter in the destructured options and the call to
promiseSpawn which currently chooses between 'tsgo' and 'tsc'). Ensure no other
logic needs changing and update any related docstring/comments if present.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9691810d-60a6-4d53-9845-59745993b7f0

📥 Commits

Reviewing files that changed from the base of the PR and between c8a8eeb and 7fc5dda.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (8)
  • .vscode/settings.json
  • .zed/settings.json
  • libs/tsc/src/executors/typecheck/executor.ts
  • libs/tsc/src/executors/typecheck/schema.d.ts
  • libs/tsc/src/executors/typecheck/schema.json
  • nx.json
  • package.json
  • tsconfig.base.json
💤 Files with no reviewable changes (1)
  • tsconfig.base.json

@philiplehmann
philiplehmann merged commit 191f32b into main Apr 16, 2026
2 of 22 checks passed
@philiplehmann
philiplehmann deleted the feature/tsc-to-tsgo branch April 16, 2026 04:29
@coderabbitai coderabbitai Bot mentioned this pull request Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant