Repository navigation
move from tsc to tsgo - #1033
Conversation
- Add `@typescript/native-preview` dependency - Add `tsgo` option to tsc typecheck executor and schema - Update nx.json to enable tsgo for typecheck - Update editor configs for tsgo support - Remove typescript dependency from package.json
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 50 minutes and 23 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (13)
📝 WalkthroughWalkthroughThis PR introduces support for Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
libs/tsc/src/executors/typecheck/executor.ts (1)
20-34:⚠️ Potential issue | 🔴 CriticalChange the default
tsgoparameter fromfalsetotrue.The executor defaults to spawning
tscon line 34, but thetypescriptpackage has been removed and replaced with@typescript/native-preview, which only provides thetsgobinary. All 13+ projects using the@riwi/tsc:typecheckexecutor with empty options will fail at runtime with "command not found: tsc".Fix
- { tsconfig = 'tsconfig.lib.json', tsgo = false }, + { tsconfig = 'tsconfig.lib.json', tsgo = true },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@libs/tsc/src/executors/typecheck/executor.ts` around lines 20 - 34, The executor's default option sets tsgo = false causing promiseSpawn to call 'tsc' by default; change the parameter default from tsgo = false to tsgo = true in the executor signature so that promiseSpawn(...) uses 'tsgo' (refer to the parameter in the destructured options and the call to promiseSpawn which currently chooses between 'tsgo' and 'tsc'). Ensure no other logic needs changing and update any related docstring/comments if present.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@libs/tsc/src/executors/typecheck/executor.ts`:
- Around line 20-34: The executor's default option sets tsgo = false causing
promiseSpawn to call 'tsc' by default; change the parameter default from tsgo =
false to tsgo = true in the executor signature so that promiseSpawn(...) uses
'tsgo' (refer to the parameter in the destructured options and the call to
promiseSpawn which currently chooses between 'tsgo' and 'tsc'). Ensure no other
logic needs changing and update any related docstring/comments if present.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9691810d-60a6-4d53-9845-59745993b7f0
⛔ Files ignored due to path filters (1)
bun.lockis excluded by!**/*.lock
📒 Files selected for processing (8)
.vscode/settings.json.zed/settings.jsonlibs/tsc/src/executors/typecheck/executor.tslibs/tsc/src/executors/typecheck/schema.d.tslibs/tsc/src/executors/typecheck/schema.jsonnx.jsonpackage.jsontsconfig.base.json
💤 Files with no reviewable changes (1)
- tsconfig.base.json
Summary by CodeRabbit