Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tinygo support will need updating for tinygo 0.32 #29

Open
dkegel-fastly opened this issue Jun 4, 2024 · 0 comments
Open

tinygo support will need updating for tinygo 0.32 #29

dkegel-fastly opened this issue Jun 4, 2024 · 0 comments

Comments

@dkegel-fastly
Copy link
Contributor

Current fwd doesn’t compile with the dev branch of tinygo due to incompatibilities with the reflect package introduced in reflect: use int in StringHeader and SliceHeader on non-AVR platforms by ydnar · Pull Request #4156 · tinygo-org/tinygo .

The symptom is

../../../../../pkg/mod/github.com/philhofer/[email protected]/writer_tinygo.go:15:9: cannot use l (variable of type uintptr) as int value in struct literal

A fix might be to use the safer, portable functions suggested in tinygo-org/tinygo#1284 ?
dkegel-fastly added a commit to dkegel-fastly/fwd that referenced this issue Jun 11, 2024
@dkegel-fastly
unsafestr: update to use unsafe.Slice()
6f258b6 
Adds support for tinygo 0.32, thereby fixing philhofer#29

Passes tests on macos intel:
- go 1.21.9:
	- go test
- go 1.21.9 / tinygo 0.32 prerelease:
	- tinygo test
	- tinygo test -target wasi
@dkegel-fastly dkegel-fastly mentioned this issue Jun 11, 2024
Merged
philhofer pushed a commit that referenced this issue Jun 12, 2024
@dkegel-fastly @philhofer
unsafestr: update to use unsafe.Slice()
fbbf495 
Adds support for tinygo 0.32, thereby fixing #29

Passes tests on macos intel:
- go 1.21.9:
	- go test
- go 1.21.9 / tinygo 0.32 prerelease:
	- tinygo test
	- tinygo test -target wasi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dkegel-fastly