Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Django 4.0 and python 3.10 #223

Closed
philgyford opened this issue Oct 4, 2021 · 5 comments
Closed

Add support for Django 4.0 and python 3.10 #223

philgyford opened this issue Oct 4, 2021 · 5 comments
Assignees
@philgyford
Labels
enhancement in progress

Comments

@philgyford
Copy link
Owner

philgyford commented Oct 4, 2021 •
edited
Loading

No description provided.

@philgyford philgyford self-assigned this Oct 4, 2021
philgyford added a commit that referenced this issue Oct 16, 2021
@philgyford
Start of support for Django 4.0
120d014 
* Updated tests to test with Django 4.01a
* Made a fix to remove use of `django.utils.encoding.force_text` that
  is removed in 4.0

However, django-imagekit doesn't currently support 4.0 – is uses the
same `force_text`. So having to stop here.

For #223
@philgyford
Copy link
Owner Author

Waiting for django-imagekit to support Django 4.0.

philgyford added a commit that referenced this issue Dec 15, 2021
@philgyford
Start adding support for Django 4.0 and python 3.10
34fbce6 
It *should* probably all work once django-taggit releases a version
that supports Django 4.0 and python 3.10.

See jazzband/django-taggit#776

For #223
@philgyford
Copy link
Owner Author

Now waiting for django-taggit to support Django 4.0 and python 3.10

@philgyford philgyford changed the title Check for support for Django 4.0 Add support for Django 3.0 and python 3.10 Dec 15, 2021
@philgyford philgyford mentioned this issue Dec 15, 2021
Closed
@philgyford philgyford changed the title Add support for Django 3.0 and python 3.10 Add support for Django 4.0 and python 3.10 Dec 15, 2021
@garrettc
Copy link
Contributor

Looks like django-taggit 2.10 now has support for Django 4 and Python 3.10. It was something that the Wagtail team were waiting for too.

@philgyford
Copy link
Owner Author

Yes, I saw that! Phew. I'll try and update at some point in the next few days.

@philgyford
Copy link
Owner Author

Django 4.0 and python 3.10 should be working in the v2 branch now, although I'm also going to be adding/fixing some other stuff before releasing v2.0 so things may break on there between now and then! Either way, I'll do a release Monday 14th at the latest.

@philgyford philgyford mentioned this issue Feb 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philgyford philgyford

Labels
enhancement in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garrettc @philgyford