Skip to content
This repository was archived by the owner on Nov 15, 2024. It is now read-only.

Convert autocomplete filed to hidden fields - #422

Merged
muhammadnadeem merged 2 commits into
developfrom
mnadeem/LP-843
Apr 6, 2018
Merged

Convert autocomplete filed to hidden fields#422
muhammadnadeem merged 2 commits into
developfrom
mnadeem/LP-843

Conversation

@muhammadnadeem

Copy link
Copy Markdown

No description provided.

@muhammadnadeem muhammadnadeem self-assigned this Apr 6, 2018
@muhammadnadeem
muhammadnadeem requested a review from zee-pk April 6, 2018 14:23
Comment thread lms/djangoapps/onboarding/forms.py Outdated
'language': forms.TextInput(attrs={"autocomplete": "off"}),
'country_of_employment': forms.TextInput(attrs={"autocomplete": "off"}),
'city_of_employment': forms.TextInput(attrs={"autocomplete": "off"}),
'country_of_employment': forms.HiddenInput(),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove optional parenthesis from function calls, like forms.HiddenInput() to keep the code symmetry.

@zee-pk zee-pk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muhammadnadeem
muhammadnadeem merged commit 1f404e9 into develop Apr 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants