Open
Conversation
mkroening
force-pushed
the
no-option
branch
2 times, most recently
from
eadbabe to
a8085c4
Compare
Contributor
Author
|
Unfortunately, I have rediscovered matklad/once_cell#72. See Is there a manual Hopefully, we will be able to do this on stable in the future. Feel free to close this if you'd rather have this closed in the meantime. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the value's type from
UnsafeCell<Option<T>>toUnsafeCell<MaybeUninit<T>>, reducing the size of the cell for types without niches.This is possible since the discriminant of
Someinvalueis also encoded asCOMPLETEinstate.