Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: File Agent Storage #1596

Merged
merged 38 commits into from
Dec 18, 2024
Merged

Feat: File Agent Storage #1596

merged 38 commits into from
Dec 18, 2024

Conversation

manthanguptaa
Copy link
Contributor

@manthanguptaa manthanguptaa commented Dec 18, 2024 •
edited
Loading

Description

This PR introduces json and yaml as a possible agent storage option to store agent session data if files (.json and .yaml)

Type of change

Please check the options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Model update
  • Infrastructure change

Checklist

  • My code follows Phidata's style guidelines and best practices
  • I have performed a self-review of my code
  • I have added docstrings and comments for complex logic
  • My changes generate no new warnings or errors
  • I have added cookbook examples for my new addition (if needed)
  • I have updated requirements.txt/pyproject.toml (if needed)
  • I have verified my changes in a clean environment

Additional Notes

Include any deployment notes, performance implications, or other relevant information:

@traverseda @manthanguptaa
feat: Create GenericFileStorage class for agent storage implementation
e45fa6a
@traverseda @manthanguptaa
feat: Implement JsonFileStorage class for JSON data handling
979c0f8
@traverseda @manthanguptaa
feat: Implement basic file operations in GenericFileStorage class
8659e9f
@traverseda @manthanguptaa
feat: Add abstract method serialize to GenericFileStorage class
5d0168d
@traverseda @manthanguptaa
refactor: Refactor GenericFileStorage to subclass AgentStorage and im…
829a969 
…plement methods
@traverseda @manthanguptaa
feat: Add abstract methods for serialization and deserialization in s…
13b58b8 
…torage
@traverseda @manthanguptaa
feat: Create by_id and by_name directories for file storage management
57388bd
@traverseda @manthanguptaa
feat: Add fileExtension property to support multiple file types
e991711
@traverseda @manthanguptaa
feat: Add YamlFileStorage class for YAML-based file handling
490d3ac
@traverseda @manthanguptaa
feat: Add optional by_name parameter to GenericFileStorage initializer
e89f700
@traverseda @manthanguptaa
feat: Create symlink in by_name directory for each session entry
acc69dc
@traverseda @manthanguptaa
feat: add get_all_session_ids_and_names method to GenericFileStorage …
594a05a 
…class
@traverseda @manthanguptaa
feat: add get_all_session_ids_and_names method and fix abstractmethod…
8946299 
… import error
@traverseda @manthanguptaa
refactor: add abstract method decorator to serialize in GenericFileSt…
6adccd4 
…orage class
@traverseda @manthanguptaa
fix: remove redundant return statements in GenericFileStorage methods
d1cd272
@traverseda @manthanguptaa
fix: ensure consistent use of self.fileExtension instead of hardcoded…
f6fd2be 
… .json in GenericFileStorage class
@traverseda @manthanguptaa
test: add common test suite for SQLite and YAML file storage implemen…
bcf66aa 
…tations
@traverseda @manthanguptaa
fix: update relative imports to absolute imports in storage test files
1f0fb55
@traverseda @manthanguptaa
fix: resolve ModuleNotFoundError by updating import statements in tes…
83b3952 
…t files to use relative imports
@traverseda @manthanguptaa
fix: add __init__.py to storage directory to enable relative imports …
c3991e7 
…in tests
@traverseda @manthanguptaa
fix: resolve AttributeError in storage tests by ensuring proper initi…
1f2671c 
…alization of storage and agent_data
@traverseda @manthanguptaa
fix: update AgentSession initialization to include agent_data in stor…
1843591 
…age tests
@traverseda @manthanguptaa
fix: remove unexpected keyword argument 'agent_data' from storage ini…
e0d71ba 
…tializations in tests
@traverseda @manthanguptaa
fix: initialize storage attribute in BaseStorageTest to ensure proper…
62fc1dc 
… subclass implementation
@traverseda @manthanguptaa
refactor: Prevent direct instantiation of BaseStorage and ensure agen…
0783595 
…t_data is initialized in tests
@traverseda @manthanguptaa
feat: add serialize method to JsonFileStorage for writing data to JSO…
d89a04b 
…N file
@traverseda @manthanguptaa
test: add unit tests for JsonFileStorage functionality
e319ff3
@traverseda @manthanguptaa
fix: resolve TypeError in JsonFileStorage.serialize method by updatin…
7143442 
…g argument handling
@traverseda @manthanguptaa
fix: correct serialize method to use path parameter instead of defaul…
d077a10 
…t path value
@traverseda @manthanguptaa
fix: update deserialize method to accept path parameter in JsonFileSt…
88e25db 
…orage
@manthanguptaa manthanguptaa mentioned this pull request Dec 18, 2024
Closed
dirkbrnd
dirkbrnd reviewed Dec 18, 2024
View reviewed changes
phi/storage/agent/json.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add docstrings to this and the yaml one.

@dirkbrnd dirkbrnd merged commit 4dcfa14 into main Dec 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkbrnd dirkbrnd dirkbrnd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manthanguptaa @dirkbrnd @traverseda