Fix: function tools description #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkbrnd
reviewed
Dec 16, 2024
| @@ -175,7 +175,7 @@ def process_entrypoint(self, strict: bool = False): | |||
| except Exception as e: | |||
| logger.warning(f"Could not parse args for {self.name}: {e}", exc_info=True) | |||
|
|
|||
| self.description = getdoc(self.entrypoint) | |||
| self.description = getdoc(self.entrypoint) or self.description | |||
There was a problem hiding this comment.
So the entrypoint doc should overwrite it?
There was a problem hiding this comment.
If the function has docstring it's good else go with the description
dirkbrnd
approved these changes
Dec 16, 2024
ysolanky
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The transfer tool function has an empty description which was causing an issue with AWSBedrock Claude as it didn't want an empty description of the tool.
Fixes #1539
Type of change
Please check the options that are relevant:
Checklist
Additional Notes
Include any deployment notes, performance implications, or other relevant information: