Set rounded corners diameter automatically for Vsmart Live.

[aljjo]

With no java or kotlin knowledge, I've searched around a lot to debug these little lines. But it feels great to make it works.
Please tell me if this needs any modification. Thank you.

[phhusson]

Looks good to me. I would just like you to run two tests: Test A: - Set manually the value to for instance 30 - Reboot - Check that the actually icon offset is indeed 30 in the status bar Test B: - Set manually to 30 - Wait for status bar to update and display the "30" value - Set parameter to -1 - Reboot - Check that the actual icon offset is indeed 12 as expected Le mar. 16 juin 2020 à 17:18, aljjo <[email protected]> a écrit :

…

With no java or kotlin knowledge, I've searched around a lot to debug these little lines. But it feels great to make it works. Please tell me if this needs any modification. Thank you. ------------------------------ You can view, comment on, or merge this pull request online at: #32 Commit Summary - Set rounded corners diameter automatically for Vsmart Live. File Changes - *M* app/src/main/java/me/phh/treble/app/EntryService.kt <https://github.com/phhusson/treble_app/pull/32/files#diff-9735a537b04f30bab1b1c26a38f23cdd> (2) - *M* app/src/main/java/me/phh/treble/app/OverlayPicker.kt <https://github.com/phhusson/treble_app/pull/32/files#diff-321880753593dab05793c5cb16df7c07> (11) Patch Links: - https://github.com/phhusson/treble_app/pull/32.patch - https://github.com/phhusson/treble_app/pull/32.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#32>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAA4OS7SE3IOHTR6R5SFMDRW6ENJANCNFSM4N7XC3DQ> .

[aljjo]

I added curly brackets to fix the if statement. Now test A and B run as expected.