Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request intends to address #2.
Despite Radium not yet being compatible with React 0.13 (FormidableLabs/radium#92), I think there are other implications that can be discussed in the meantime.
The [Radium docs](https://github.com/formidablelabs/radium/blob/master/docs/guides/media-q
ueries.md) say this:
Note: this means descendent as in view hierarchy, not class inheritance.
Since this project didn't have a single high level component, the first commit introduces an app router which is loosely based on the [shared root example](https://github.com/rackt/react-router/blob/master/examples/shared-root/a
pp.js) from React Router.
While there are further potential changes in this area to bring Essential React closer to the given example, those are not (yet) addressed here.
The second commit outlines how Radium could/would be added. These changes have been left as comments in order to keep the project compatible with 0.13 and allow any further refactoring of components.
Concerns
MatchMediaItem
mixin is being applied to pages I did wonder if it should instead be applied toLoggedInRouter
andLoggedOutRouter
.Should the project be refactored and brought closer to the React Router example, some of these concerns might be redundant.
There are other aspects to Radium which have little (if any) implications and have yet to be implemented for that reason.
Looking for some input from @pheuter on how best to proceed.