fixed form for warnings

phenixdigital · Feb 14, 2023 · f5c9dea · f5c9dea
1 parent 0c72d10
commit f5c9dea
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 7 deletions.
diff --git a/guides/components.md b/guides/components.md
@@ -146,7 +146,7 @@ In template, you can pass some extra attributes to your variation. Just add them
 
 ```elixir
 """
-<.form_for for={:user} :let={f}>
+<.form_for :let={f} for={%{}} as={:user}>
   <.lsb-variation form={f}/>
 </.form>
 """

diff --git a/lib/phx_live_storybook/live/search.ex b/lib/phx_live_storybook/live/search.ex
@@ -55,7 +55,14 @@ defmodule PhxLiveStorybook.Search do
           phx-click-away={JS.dispatch("lsb:close-search")}
           class="lsb lsb-opacity-0 lsb-scale-90 lsb-mx-auto lsb-max-w-xl lsb-mt-16 lsb-transform lsb-divide-y lsb-divide-gray-100 lsb-overflow-hidden lsb-rounded-xl lsb-bg-white lsb-shadow-2xl lsb-transition-all"
         >
-          <.form :let={f} for={:search} phx-debounce={500} id="search-form" class="lsb lsb-relative">
+          <.form
+            :let={f}
+            for={%{}}
+            as={:search}
+            phx-debounce={500}
+            id="search-form"
+            class="lsb lsb-relative"
+          >
             <.fa_icon
               style={:light}
               name="search"

diff --git a/lib/phx_live_storybook/live/story/playground.ex b/lib/phx_live_storybook/live/story/playground.ex
@@ -338,7 +338,8 @@ defmodule PhxLiveStorybook.Story.Playground do
     ~H"""
     <.form
       :let={f}
-      for={:playground}
+      for={%{}}
+      as={:playground}
       id={form_id(@story)}
       phx-change="playground-change"
       phx-target={@myself}
@@ -462,7 +463,8 @@ defmodule PhxLiveStorybook.Story.Playground do
     <%= unless Enum.empty?(@story.merged_attributes()) do %>
       <.form
         :let={f}
-        for={:variation}
+        for={%{}}
+        as={:variation}
         id="variation-selection-form"
         class="lsb lsb-flex lsb-flex-col md:lsb-flex-row lsb-space-y-1 md:lsb-space-x-2 lsb-justify-end lsb-w-full lsb-mb-6"
       >

diff --git a/lib/phx_live_storybook/live/story_live.ex b/lib/phx_live_storybook/live/story_live.ex
@@ -283,7 +283,8 @@ defmodule PhxLiveStorybook.StoryLive do
       <!-- mobile version of navigation tabs -->
       <.form
         :let={f}
-        for={:navigation}
+        for={%{}}
+        as={:navigation}
         id={"#{Macro.underscore(@story)}-navigation-form"}
         class="lsb story-nav-form lg:lsb-hidden"
       >

diff --git a/priv/templates/phx.gen.storybook/core_components/input.story.exs.eex b/priv/templates/phx.gen.storybook/core_components/input.story.exs.eex
@@ -7,7 +7,7 @@ defmodule Storybook.CoreComponents.Input do
 
   def template do
     """
-    <.simple_form for={:story} :let={f} class="w-full">
+    <.simple_form :let={f} for={%{}} as={:story} class="w-full">
       <.lsb-variation-group field={{f, :field}}/>
     </.simple_form>
     """

diff --git a/priv/templates/phx.gen.storybook/examples/core_components.story.exs.eex b/priv/templates/phx.gen.storybook/examples/core_components.story.exs.eex
@@ -52,7 +52,8 @@ defmodule Storybook.Examples.CoreComponents do
       <:subtitle>This won't be persisted into DB, memory only</:subtitle>
       <.simple_form
         :let={f}
-        for={:user}
+        for={%{}}
+        as={:user}
         phx-submit={JS.push("save_user") |> hide_modal("new-user-modal")}
       >
         <.input field={{f, :first_name}} label="First name" />