Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix temperature error code despite success status code #174

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

lisabiermann
Copy link
Collaborator

This PR fixes #173.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.69%. Comparing base (de18540) to head (b4d9856).
Report is 20 commits behind head on develop.

Files with missing lines Patch % Lines
src/bounce_solution/bounce_solution.cpp 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #174      +/-   ##
===========================================
- Coverage    83.18%   82.69%   -0.49%     
===========================================
  Files           54       54              
  Lines        18742    19344     +602     
  Branches      1841     1847       +6     
===========================================
+ Hits         15590    15997     +407     
- Misses        3152     3347     +195     
Flag Coverage Δ
unittests 82.69% <50.00%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lisabiermann lisabiermann added the bug Something isn't working label Nov 6, 2024
@lisabiermann lisabiermann linked an issue Nov 6, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant