Fixes for handling SML and directory related configuration keys #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phax
reviewed
Jul 30, 2024
| @@ -100,7 +105,7 @@ public SMPSettingsManagerMongoDB () | |||
| } | |||
|
|
|||
| @Nonnull | |||
| @ReturnsMutableObject | |||
| @aTargeturnsMutableObject | |||
phax
reviewed
Jul 30, 2024
| ret.setSMLRequired (StringParser.parseBool (aValues.get (SML_REQUIRED), SMPSettings.DEFAULT_SML_REQUIRED)); | ||
| ret.isDirectoryIntegrationAutoUpdate ())); | ||
| String sDirectoryHostName = aValues.get (DIRECTORY_HOSTNAME); | ||
| if (sDirectoryHostName == null) |
phax
reviewed
Jul 30, 2024
| aTarget.setSMLEnabled (aDoc.getBoolean (BSON_SML_ENABLED, SMPSettings.DEFAULT_SML_ENABLED)); | ||
| aTarget.isDirectoryIntegrationAutoUpdate ())); | ||
| String sDirectoryHostName = aDoc.getString (BSON_DIRECTORY_HOSTNAME); | ||
| if (sDirectoryHostName == null) |
phax
added a commit
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While configuring a new instance of the latest (7.1.0) SQL version I noticed that some properties from the configuration files were not taken into account and always needed to be changed via the settings UI.
Looking closer into the issue I noticed a few problems:
application.propertiesresource shipped within the app had the new keys define that prevented the old keys from being readThis PR fixes these by: