-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for handling SML and directory related configuration keys #267
Conversation
@@ -100,7 +105,7 @@ public SMPSettingsManagerMongoDB () | |||
} | |||
|
|||
@Nonnull | |||
@ReturnsMutableObject | |||
@aTargeturnsMutableObject |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo to fix
ret.setSMLRequired (StringParser.parseBool (aValues.get (SML_REQUIRED), SMPSettings.DEFAULT_SML_REQUIRED)); | ||
ret.isDirectoryIntegrationAutoUpdate ())); | ||
String sDirectoryHostName = aValues.get (DIRECTORY_HOSTNAME); | ||
if (sDirectoryHostName == null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use hasNoText
aTarget.setSMLEnabled (aDoc.getBoolean (BSON_SML_ENABLED, SMPSettings.DEFAULT_SML_ENABLED)); | ||
aTarget.isDirectoryIntegrationAutoUpdate ())); | ||
String sDirectoryHostName = aDoc.getString (BSON_DIRECTORY_HOSTNAME); | ||
if (sDirectoryHostName == null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use hasNoText
While configuring a new instance of the latest (7.1.0) SQL version I noticed that some properties from the configuration files were not taken into account and always needed to be changed via the settings UI.
Looking closer into the issue I noticed a few problems:
application.properties
resource shipped within the app had the new keys define that prevented the old keys from being readThis PR fixes these by: