New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refinement of new logging API usage. #124

Merged

febbraro merged 1 commit into develop from spinner/power

Nov 17, 2017

Contributor

grayside commented Nov 17, 2017

Here is another batch of changes related to the logging API.

Use the main logging API instead of the sidestepping when it's not needed.
Found a few places to tweak how the spinner is used.
Found a couple negated log messages.
String tweaks for clarity/accuracy.

This was done with a line-by-line audit of the code, I think that's about it for improvements of the messaging without live testing.


          Refinement of new logging API usage.

fa741c8

grayside requested a review from febbraro

November 17, 2017 06:25

febbraro approved these changes

View reviewed changes

febbraro merged commit 29fb57a into develop

febbraro deleted the spinner/power branch

November 17, 2017 18:43

grayside added this to the v2.1 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet