Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor IceTipTreeNode to support use of a FormSet #1808

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

Rinzwind
Copy link
Contributor

This pull request refactors IceTipTreeNode to support use of a FormSet (introduced in Pharo pull request #14998) for the icon and applies that to #repositoryModelsByGroup on IceTipRepositoryModel.

@Rinzwind
Copy link
Contributor Author

There are two additional commits that I did not include in this pull request: commits a9abd57 and 9fd5505. Commit a9abd57 would change the SpImageTableColumn’s answer for #readObject: from a Form to a FormSet. That would not be a problem for #visitImageColumn: on SpMorphicTableCellBuilder as it just sends the answer #asMorph. But other uses of the SpImageTableColumn could break. I’m guessing that’s at least the case for ‘Spec-Gtk’.

@Rinzwind Rinzwind changed the base branch from Pharo12 to dev-2.0 February 25, 2024 23:59
@estebanlm estebanlm changed the base branch from dev-2.0 to Pharo12 February 26, 2024 08:39
@Ducasse Ducasse merged commit cb4e166 into pharo-vcs:Pharo12 Mar 20, 2024
2 of 4 checks passed
@Rinzwind Rinzwind deleted the icetiptreenode-formset branch March 29, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants