Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci issues #1797

Merged
merged 3 commits into from
Jan 28, 2024
Merged

Ci issues #1797

merged 3 commits into from
Jan 28, 2024

Conversation

hernanmd
Copy link

This PR address two current errors reported by the Pharo CI:

  • First one is a simple uncategorized method
  • Second one is an unused method in a trait.
ProperMethodCategorizationTest
 ✗ #testNoUncategorizedMethods (15ms)
TestFailure: the following classes have uncategorized methods: an OrderedCollection(IceTipPackageModel class)
ProperMethodCategorizationTest(TestAsserter)>>assert:description:resumable:
ProperMethodCategorizationTest(TestAsserter)>>assert:description:
ProperMethodCategorizationTest>>testNoUncategorizedMethods ...assert: remaining isEmpty description: 'the following classes have uncategorized methods: ' , remaining asString
ProperMethodCategorizationTest(TestCase)>>performTest

ReleaseTest
 ✗ #testThatThereAreNoSelectorsRemain...tAreSentButNotImplemented (658ms)
TestFailure: an OrderedCollection('DeprecationTest>>#testTransformingDeprecation' 'IceTipCherryPickCommand>>#selectedCommitish' 'IceTipInspectCommand>>#item' 'TIceRepositoryReader classTrait>>#id' 'TIceRepositoryWriter classTrait>>#id') should have been empty
ReleaseTest(TestAsserter)>>assert:description:resumable:
ReleaseTest(TestAsserter)>>assert:description:
ReleaseTest(TestAsserter)>>assertEmpty:
ReleaseTest>>testThatThereAreNoSelectorsRemainingThatAreSentButNotImplemented ...assertEmpty: (violations difference: knownFailures)
ReleaseTest(TestCase)>>performTest

The problem with the unused method id is the required message, which is not implemeted.

The only user is IceRepositoryProperties>>readerClass. This method sends users as follows:

readerClass
	^ TIceRepositoryReader users detect: [ :each | each id = self fileFormat id  ]

so the users could be:

  • IceLibgitTonelReader
  • IceLibgitFiletreeReader

which have their own implementation of id, answering #tonel or #filetree

The required method was implemented in MetacelloMCVersionSpecLoader as:

required

	required == nil ifTrue: [ ^#() ].
	^ required

but it is not present anymore.

@hernanmd
Copy link
Author

IceTipInspectCommand>>item is sending an unimplemented message.
realObject was present in IceTipCachedModel, but that class was removed.
Since this method is only calling super and Iceberg cached model was deleted, it seems we could safely remove it.

@Ducasse Ducasse merged commit 79ade7c into pharo-vcs:dev-2.0 Jan 28, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants