Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misspellings of ‘committing’, ‘committed’ and ‘uncommitted’ in literal strings #1754

Merged
merged 1 commit into from
Nov 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ IceGitHubNewPullRequestAction >> validateMakePullRequestOn: aRepository [

| status |
status := OrderedCollection new: 2.
aRepository isModified ifTrue: [ status add: 'Uncommited changes' ].
aRepository isModified ifTrue: [ status add: 'Uncommitted changes' ].
(aRepository outgoingCommitsTo: remote) ifNotEmpty: [ :commits |
'{1} not published' format: { commits size } ].
status ifEmpty: [ ^ true ].
Expand Down
2 changes: 1 addition & 1 deletion Iceberg-Tests/IceGitMergeTest.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ IceGitMergeTest >> testMergeWithMissingProjectFile [
fileRef := self repository location / 'test1.txt'.
fileRef writeStreamDo: [ :stream | stream << 'test1' ].
self repository index addPath: (fileRef relativeTo: self repository location).
self repository commitWithMessage: 'commiting something'.
self repository commitWithMessage: 'committing something'.
incomingBranch := self repository branch.

self repository checkoutBranch: 'master'.
Expand Down
6 changes: 3 additions & 3 deletions Iceberg-TipUI/IceTipCommentPanel.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -85,14 +85,14 @@ IceTipCommentPanel >> initializePresenters [
add: (self newToolbarToggleButton
icon: (self application iconNamed: #smallSave);
label: 'Save image';
help: 'Save image when commiting';
help: 'Save image when committing';
state: self isSaving;
whenChangedDo: [ :aBoolean | self saveOnCommit: aBoolean ];
yourself);
add: (self newToolbarToggleButton
icon: (self application iconNamed: #smallError);
label: 'Run critics';
help: 'Run critics when commiting';
help: 'Run critics when committing';
state: self isRunningCriticsOnCommit;
whenChangedDo: [ :aBoolean | self runCriticsOnCommit: aBoolean ];
yourself);
Expand All @@ -113,7 +113,7 @@ IceTipCommentPanel >> initializePresenters [
placeholder: 'A comment for your commit';
yourself.

fixesHelpString := 'Enter the number of the issue that you fixed. Github will close it when it will be commited or merged in the default branch'.
fixesHelpString := 'Enter the number of the issue that you fixed. Github will close it when it will be committed or merged in the default branch'.
fixesLabel := self newLabel
label: 'Fixes #';
help: fixesHelpString;
Expand Down
2 changes: 1 addition & 1 deletion Iceberg-TipUI/IceTipCommitAction.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Class {
IceTipCommitAction >> basicExecute [
self validateCanCommit.
UIManager default
informUser: 'Commiting...'
informUser: 'Committing...'
during: [
self repository
commitChanges: (diff copyWithOnly: items)
Expand Down
2 changes: 1 addition & 1 deletion Iceberg-TipUI/IceTipInteractiveErrorVisitor.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ IceTipInteractiveErrorVisitor >> visitShouldCommitBeforePullError: anError [
| continue |
continue := context application newConfirm
label:
'Your repository has uncommited changes. Merging incoming commits will change
'Your repository has uncommitted changes. Merging incoming commits will change
your current working copy and your current state will not be recoverable.
We recommend that you commit first and then pull incoming changes again.';
title: 'You might loose your current changes!';
Expand Down
2 changes: 1 addition & 1 deletion Iceberg-TipUI/IceTipPackageModel.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ IceTipPackageModel >> status [
[
self entity repository isMissing ifTrue: [ ^ 'Local repository missing' ].
self entity isLoaded ifFalse: [ ^ 'Not loaded' ].
self entity isModified ifTrue: [ ^ 'Uncommited changes' ].
self entity isModified ifTrue: [ ^ 'Uncommitted changes' ].
^ 'Up to date' ]
on: Error do: [ :e |
^ e description ]
Expand Down
2 changes: 1 addition & 1 deletion Iceberg-TipUI/IceTipRepairCheckoutBranch.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ This situation happens because the code loaded in your image does not correspond

This action opens a preview window before doing any change.

This operation will modify the state of your working copy on disk. All non-commited changes in your disk working copy that are not in the image will be lost (this can happen if you edited the repository from outside). If you want to keep them, perform a commit from outside before.'
This operation will modify the state of your working copy on disk. All non-committed changes in your disk working copy that are not in the image will be lost (this can happen if you edited the repository from outside). If you want to keep them, perform a commit from outside before.'
]

{ #category : #accessing }
Expand Down
2 changes: 1 addition & 1 deletion Iceberg-TipUI/IceTipRepairCheckoutNewBranch.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ This will not lose any change in the image.

This situation happens because the code loaded in your image does not correspond with the status of your repository.

This operation will modify the state of your working copy on disk. All non-commited changes in your disk working copy that are not in the image will be lost (this can happen if you edited the repository from outside). If you want to keep them, perform a commit from outside before.'
This operation will modify the state of your working copy on disk. All non-committed changes in your disk working copy that are not in the image will be lost (this can happen if you edited the repository from outside). If you want to keep them, perform a commit from outside before.'
]

{ #category : #accessing }
Expand Down
4 changes: 2 additions & 2 deletions Iceberg-TipUI/IceTipRepairCreateSubdirectory.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ IceTipRepairCreateSubdirectory class >> help [
^ 'Create a new subdirectory for the code.

The configured source directory does not exist in the repository.
It is possible that the directory has been deleted or never commited after creating the meta-data.
It is possible that the directory has been deleted or never committed after creating the meta-data.

This operation will modify the state of your working copy on disk. All non-commited changes in your disk working copy that are not in the image will be lost (this can happen if you edited the repository from outside). If you want to keep them, perform a commit from outside before.'
This operation will modify the state of your working copy on disk. All non-committed changes in your disk working copy that are not in the image will be lost (this can happen if you edited the repository from outside). If you want to keep them, perform a commit from outside before.'
]

{ #category : #accessing }
Expand Down
2 changes: 1 addition & 1 deletion Iceberg-TipUI/IceTipRepairDiscardAndLoad.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ IceTipRepairDiscardAndLoad class >> help [

This action will synchronize your image with the code in the repository.

All the changes in the image that have not been commited will be lost.
All the changes in the image that have not been committed will be lost.

This situation happens because loaded code in your image is from a different commit than the current commit (HEAD) in the repository.

Expand Down
2 changes: 1 addition & 1 deletion Iceberg-TipUI/IceTipRepairMergeWithBranch.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ This will not lose any change in the image but may lead to conflicts. If there a

This situation happens because loaded code in your image is from a different commit than the current commit (HEAD) in the repository.

This operation will modify the state of your working copy in disk, the checkouted branch will replace the disk working copy. All non-commited changes in your disk working copy will be lost. If you want to keep them, perform a commit from outside before.'
This operation will modify the state of your working copy in disk, the checkouted branch will replace the disk working copy. All non-committed changes in your disk working copy will be lost. If you want to keep them, perform a commit from outside before.'
]

{ #category : #accessing }
Expand Down
2 changes: 1 addition & 1 deletion Iceberg-TipUI/IceTipRepairPullRemoteBranch.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ This will not lose any change in the image.

This situation happens because the code loaded in your image is not in the branch currently selected on your repository.

This operation will modify the state of your working copy in disk. All non-commited changes in your disk working copy that are not in the image will be lost. If you want to keep them, perform a commit from outside before.'
This operation will modify the state of your working copy in disk. All non-committed changes in your disk working copy that are not in the image will be lost. If you want to keep them, perform a commit from outside before.'
]

{ #category : #accessing }
Expand Down
4 changes: 2 additions & 2 deletions Iceberg-TipUI/IceTipRepositoryModel.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ IceTipRepositoryModel >> status [
self isLoaded ifFalse: [ ^ 'Not loaded' ].

status := OrderedCollection new.
entity isModified ifTrue: [ status add: 'Uncommited changes' ].
entity isModified ifTrue: [ status add: 'Uncommitted changes' ].

incoming := self incomingCommits size.
incoming > 0 ifTrue: [ status add: ('{1} incoming' format: { incoming })].
Expand Down Expand Up @@ -510,7 +510,7 @@ IceTipRepositoryModel >> statusString [
self isLoaded ifFalse: [ ^ 'Not loaded' ].

status := OrderedCollection new.
entity isModified ifTrue: [ status add: 'Uncommited changes' ].
entity isModified ifTrue: [ status add: 'Uncommitted changes' ].

incoming := self incomingCommits size.
incoming > 0 ifTrue: [ status add: ('{1} incoming' format: { incoming })].
Expand Down
6 changes: 3 additions & 3 deletions Iceberg/IceTipCommitSettings.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -80,21 +80,21 @@ IceTipCommitSettings class >> settingsOn: aBuilder [
noOrdering;
target: self;
default: self critiquesOnCommitDefaultValue;
label: 'Run Code Critiques when commiting';
label: 'Run Code Critiques when committing';
description:
'Check if you want to run the code critiques on the changes each time you commit them'.
(aBuilder setting: #saveImageOnCommit)
noOrdering;
target: self;
default: self saveImageOnCommitDefaultValue;
label: 'Save the image when commiting';
label: 'Save the image when committing';
description:
'Check if you want to save the image each time you commit something'.
(aBuilder setting: #pushOnCommit)
noOrdering;
target: self;
default: self pushOnCommitDefaultValue;
label: 'Push when commiting';
label: 'Push when committing';
description:
'Check if you want to push your changes each time you commit something' ]
]