Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1686-SSH-Key-pair-should-not-ask-user-it-should-use-the-user-from-the-URL #1687

Open
wants to merge 2 commits into
base: dev-2.0
Choose a base branch
from

Conversation

tesonep
Copy link
Collaborator

@tesonep tesonep commented Mar 13, 2023

The username of the SSH credential should come from the SSH URL not from the configuration.

  • Fixing the presenters
  • Fixing cancel when editing.

Fix #1686

…rom the configuration.

- Fixing the presenters
- Fixing cancel when editing.
@tesonep tesonep requested a review from guillep March 13, 2023 15:16
@estebanlm estebanlm closed this Apr 18, 2023
@estebanlm estebanlm reopened this Apr 18, 2023
@estebanlm
Copy link
Collaborator

I have valid failing tests @tesonep :)

@Ducasse
Copy link
Collaborator

Ducasse commented Jan 22, 2024

So what do we do with this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSH Key pair should not ask user, it should use the user from the URL
3 participants